Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nrfconnect] Introduced several improvements for the factory data management #33195

Merged
merged 4 commits into from
May 6, 2024
Merged

[nrfconnect] Introduced several improvements for the factory data management #33195

merged 4 commits into from
May 6, 2024

Conversation

kkasperczyk-no
Copy link
Contributor

Added following improvements for the nRFConnect factory data implementation:

  • enabled assigning of the FactoryDataProvider concrete types to the generic pointer
  • allowed to generate and support factory data on the device that is not based on the Partition Manager

markaj-nordic and others added 4 commits April 26, 2024 13:03
@markaj-nordic @kkasperczyk-no
[nrfconnect] Added FactoryDataBase to facilitate dynamic
950363c 
assignments of FactoryDataProvider concrete types to
to the generic pointer.

Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no>
@kkasperczyk-no
[nrfconnect] Added non-PM based factory data support
1a0f4f2 
Added support for platforms not built using PM. This commit
includes fixes only firmware implementation and does not include
cmake changes for factory data generation.

Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no>
@ArekBalysNordic @kkasperczyk-no
[nrfconnect] Improved generation of the factory data
3594ca7 
Allow to merge the factory data .hex file with the firmware's .hex
file when partition manager is not available.
@ArekBalysNordic @kkasperczyk-no
[nrfconnect] Disable External FD if QSPI NOR is not available
a4c7899 
We need to have support for factory data when the partition manager
is enabled but there is no support for QSPI external flash.
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited
Loading

PR #33195: Size comparison from cfb9404 to a4c7899

Increases (11 builds for nrfconnect)
platform target config section cfb9404 a4c7899 change % change
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp (read/write) 1226216 1226488 272 0.0
rodata 151384 151400 16 0.0
text 798024 798292 268 0.0
light-switch-app nrf52840dk_nrf52840 (read/write) 949596 949920 324 0.0
rodata 78276 78328 52 0.1
text 701224 701492 268 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1198988 1199316 328 0.0
rodata 178516 178572 56 0.0
text 747356 747624 268 0.0
lighting-app nrf52840dk_nrf52840+rpc (read/write) 1049556 1049884 328 0.0
rodata 83988 84044 56 0.1
text 780568 780836 268 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 947496 947824 328 0.0
rodata 79784 79840 56 0.1
text 682276 682544 268 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1198988 1199316 328 0.0
rodata 178516 178572 56 0.0
text 747356 747624 268 0.0
lock-app nrf52840dk_nrf52840 (read/write) 962004 962328 324 0.0
rodata 97836 97888 52 0.1
text 693596 693864 268 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 892248 892576 328 0.0
rodata 99264 99320 56 0.1
text 617456 617724 268 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1212328 1212656 328 0.0
rodata 198084 198140 56 0.0
text 740624 740892 268 0.0
pump-app nrf52840dk_nrf52840 (read/write) 912920 913248 328 0.0
rodata 73336 73392 56 0.1
text 670336 670604 268 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 899224 899552 328 0.0
rodata 70072 70128 56 0.1
text 660176 660444 268 0.0
Decreases (1 build for efr32)
platform target config section cfb9404 a4c7899 change % change
efr32 window-app BRD4187C (read/write) 1136028 1136020 -8 -0.0
.text 968160 968152 -8 -0.0
Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section cfb9404 a4c7899 change % change
bl602 lighting-app bl602 (read/write) 1443026 1443026 0 0.0
.bss 85720 85720 0 0.0
.data 9512 9512 0 0.0
.rodata 159092 159092 0 0.0
.text 1108044 1108044 0 0.0
bl602+mfd (read/write) 1457450 1457450 0 0.0
.bss 85888 85888 0 0.0
.data 9488 9488 0 0.0
.rodata 158052 158052 0 0.0
.text 1123362 1123362 0 0.0
bl602+rpc (read/write) 1490674 1490674 0 0.0
.bss 93760 93760 0 0.0
.data 9888 9888 0 0.0
.rodata 166660 166660 0 0.0
.text 1139690 1139690 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1209067 1209067 0 0.0
.bss 11185 11185 0 0.0
.data 3704 3704 0 0.0
.rodata 108788 108788 0 0.0
.text 978458 978458 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1219903 1219903 0 0.0
.bss 11361 11361 0 0.0
.data 3688 3688 0 0.0
.rodata 107728 107728 0 0.0
.text 990212 990212 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1300555 1300555 0 0.0
.bss 19669 19669 0 0.0
.data 4248 4248 0 0.0
.rodata 124160 124160 0 0.0
.text 1053166 1053166 0 0.0
bl706-eth (read/write) 1025433 1025433 0 0.0
.bss 23760 23760 0 0.0
.data 3256 3256 0 0.0
.rodata 101776 101776 0 0.0
.text 768334 768334 0 0.0
bl706-wifi (read/write) 1260066 1260066 0 0.0
.bss 10645 10645 0 0.0
.data 3704 3704 0 0.0
.rodata 122776 122776 0 0.0
.text 1000198 1000198 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1178404 1178404 0 0.0
.bss 16396 16396 0 0.0
.data 5072 5072 0 0.0
.rodata 102792 102792 0 0.0
.text 971312 971312 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1189804 1189804 0 0.0
.bss 16572 16572 0 0.0
.data 5048 5048 0 0.0
.rodata 101732 101732 0 0.0
.text 983634 983634 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 783668 783668 0 0.0
(read/write) 176660 176660 0 0.0
.bss 98604 98604 0 0.0
.data 3588 3588 0 0.0
.rodata 82996 82996 0 0.0
.text 700404 700404 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 799556 799556 0 0.0
(read/write) 187148 187148 0 0.0
.bss 109092 109092 0 0.0
.data 3588 3588 0 0.0
.rodata 76980 76980 0 0.0
.text 722308 722308 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 788420 788420 0 0.0
(read/write) 181268 181268 0 0.0
.bss 103212 103212 0 0.0
.data 3588 3588 0 0.0
.rodata 103900 103900 0 0.0
.text 684252 684252 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 740676 740676 0 0.0
(read/write) 175636 175636 0 0.0
.bss 97344 97344 0 0.0
.data 3580 3580 0 0.0
.rodata 78660 78660 0 0.0
.text 661748 661748 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 726300 726300 0 0.0
(read/write) 175844 175844 0 0.0
.bss 97568 97568 0 0.0
.data 3572 3572 0 0.0
.rodata 74436 74436 0 0.0
.text 651596 651596 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 587534 587534 0 0.0
(read/write) 208372 208372 0 0.0
.bss 201596 201596 0 0.0
.data 1652 1652 0 0.0
.rodata 87526 87526 0 0.0
.text 497884 497884 0 0.0
lock CC3235SF_LAUNCHXL (read only) 633702 633702 0 0.0
(read/write) 208636 208636 0 0.0
.bss 202000 202000 0 0.0
.data 1516 1516 0 0.0
.rodata 108206 108206 0 0.0
.text 523376 523376 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 570567 570567 0 0.0
.app_xip_area 460477 460477 0 0.0
.bss 64908 64908 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 552783 552783 0 0.0
.app_xip_area 438021 438021 0 0.0
.bss 69572 69572 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 573327 573327 0 0.0
.app_xip_area 464733 464733 0 0.0
.bss 63452 63452 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 565783 565783 0 0.0
.app_xip_area 454005 454005 0 0.0
.bss 66556 66556 0 0.0
.data 800 800 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4187C (read/write) 1069560 1069560 0 0.0
.bss 179920 179920 0 0.0
.data 3432 3432 0 0.0
.text 886188 886188 0 0.0
lock-app BRD4338a (read/write) 963036 963036 0 0.0
.bss 210504 210504 0 0.0
.data 30288 30288 0 0.0
.text 702880 702880 0 0.0
window-app BRD4187C (read/write) 1136028 1136020 -8 -0.0
.bss 164512 164512 0 0.0
.data 3336 3336 0 0.0
.text 968160 968152 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1215062 1215062 0 0.0
(read/write) 1751160 1751160 0 0.0
.dram0.bss 74616 74616 0 0.0
.dram0.data 13652 13652 0 0.0
.flash.rodata 253352 253352 0 0.0
.flash.text 1215062 1215062 0 0.0
.iram0.text 75570 75570 0 0.0
m5stack (read only) 1256419 1256419 0 0.0
(read/write) 537564 537564 0 0.0
.dram0.bss 81368 81368 0 0.0
.dram0.data 35196 35196 0 0.0
.flash.rodata 285080 285080 0 0.0
.flash.text 1250255 1250255 0 0.0
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2651229 2651229 0 0.0
(read/write) 130352 130352 0 0.0
.bss 47016 47016 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 75112 75112 0 0.0
.dynamic 608 608 0 0.0
.got 4520 4520 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 185040 185040 0 0.0
.text 2287077 2287077 0 0.0
all-clusters-app debug (read only) 5966129 5966129 0 0.0
(read/write) 481992 481992 0 0.0
.bss 135328 135328 0 0.0
.data 4560 4560 0 0.0
.data.rel.ro 334664 334664 0 0.0
.dynamic 624 624 0 0.0
.got 5328 5328 0 0.0
.init 27 27 0 0.0
.init_array 1440 1440 0 0.0
.rodata 351984 351984 0 0.0
.text 5178883 5178883 0 0.0
all-clusters-minimal-app debug (read only) 5246105 5246105 0 0.0
(read/write) 237944 237944 0 0.0
.bss 128160 128160 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 98248 98248 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 290634 290634 0 0.0
.text 4718867 4718867 0 0.0
bridge-app debug (read only) 4637345 4637345 0 0.0
(read/write) 218856 218856 0 0.0
.bss 118688 118688 0 0.0
.data 6240 6240 0 0.0
.data.rel.ro 87200 87200 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 230858 230858 0 0.0
.text 4184307 4184307 0 0.0
chip-tool debug (read only) 12088873 12088873 0 0.0
(read/write) 523424 523424 0 0.0
.bss 95032 95032 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 416032 416032 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 451769 451769 0 0.0
.text 10928627 10928627 0 0.0
chip-tool-ipv6only arm64 (read only) 11406612 11406612 0 0.0
(read/write) 588960 588960 0 0.0
.bss 104008 104008 0 0.0
.data 4520 4520 0 0.0
.data.rel.ro 455976 455976 0 0.0
.dynamic 512 512 0 0.0
.got 17104 17104 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 356276 356276 0 0.0
.text 10168552 10168552 0 0.0
lighting-app debug+rpc+ui (read only) 5560897 5560897 0 0.0
(read/write) 227624 227624 0 0.0
.bss 119632 119632 0 0.0
.data 4896 4896 0 0.0
.data.rel.ro 95568 95568 0 0.0
.dynamic 672 672 0 0.0
.got 5856 5856 0 0.0
.init 27 27 0 0.0
.init_array 976 976 0 0.0
.rodata 354772 354772 0 0.0
.text 4957555 4957555 0 0.0
lock-app debug (read only) 4703273 4703273 0 0.0
(read/write) 206048 206048 0 0.0
.bss 113960 113960 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 81192 81192 0 0.0
.dynamic 624 624 0 0.0
.got 5168 5168 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 256714 256714 0 0.0
.text 4233443 4233443 0 0.0
ota-provider-app debug (read only) 4313177 4313177 0 0.0
(read/write) 194520 194520 0 0.0
.bss 113728 113728 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 70480 70480 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 209514 209514 0 0.0
.text 3909059 3909059 0 0.0
ota-requestor-app debug (read only) 4443801 4443801 0 0.0
(read/write) 198888 198888 0 0.0
.bss 114624 114624 0 0.0
.data 4768 4768 0 0.0
.data.rel.ro 73584 73584 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 215594 215594 0 0.0
.text 4029059 4029059 0 0.0
shell debug (read only) 2935329 2935329 0 0.0
(read/write) 157360 157360 0 0.0
.bss 62800 62800 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 87344 87344 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 188480 188480 0 0.0
.text 2571618 2571618 0 0.0
thermostat-no-ble arm64 (read only) 4436140 4436140 0 0.0
(read/write) 243680 243680 0 0.0
.bss 122264 122264 0 0.0
.data 3408 3408 0 0.0
.data.rel.ro 104464 104464 0 0.0
.dynamic 512 512 0 0.0
.got 8720 8720 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 160388 160388 0 0.0
.text 3938808 3938808 0 0.0
tv-app debug (read only) 5778945 5778945 0 0.0
(read/write) 353752 353752 0 0.0
.bss 244528 244528 0 0.0
.data 6560 6560 0 0.0
.data.rel.ro 95368 95368 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 295722 295722 0 0.0
.text 5239347 5239347 0 0.0
tv-casting-app debug (read only) 9904481 9904481 0 0.0
(read/write) 343552 343552 0 0.0
.bss 158744 158744 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 174896 174896 0 0.0
.dynamic 624 624 0 0.0
.got 5040 5040 0 0.0
.init 27 27 0 0.0
.init_array 1216 1216 0 0.0
.rodata 385112 385112 0 0.0
.text 9052371 9052371 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2535904 2535904 0 0.0
.bss 220752 220752 0 0.0
.data 5216 5216 0 0.0
.text 1498588 1498588 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1050432 1050432 0 0.0
bss 130015 130015 0 0.0
rodata 101552 101552 0 0.0
text 771624 771624 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1226216 1226488 272 0.0
bss 126771 126771 0 0.0
rodata 151384 151400 16 0.0
text 798024 798292 268 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 997896 997896 0 0.0
bss 128873 128873 0 0.0
rodata 88816 88816 0 0.0
text 732972 732972 0 0.0
light-switch-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 949596 949920 324 0.0
bss 122934 122934 0 0.0
rodata 78276 78328 52 0.1
text 701224 701492 268 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1198988 1199316 328 0.0
bss 118947 118947 0 0.0
rodata 178516 178572 56 0.0
text 747356 747624 268 0.0
lighting-app nrf52840dk_nrf52840+rpc (read only) 4 4 0 0.0
(read/write) 1049556 1049884 328 0.0
bss 134685 134685 0 0.0
rodata 83988 84044 56 0.1
text 780568 780836 268 0.0
nrf52840dongle_nrf52840 (read only) 4 4 0 0.0
(read/write) 1004356 1004356 0 0.0
bss 142690 142690 0 0.0
rodata 73916 73916 0 0.0
text 732720 732720 0 0.0
nrf5340dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 947496 947824 328 0.0
bss 133491 133491 0 0.0
rodata 79784 79840 56 0.1
text 682276 682544 268 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1198988 1199316 328 0.0
bss 118947 118947 0 0.0
rodata 178516 178572 56 0.0
text 747356 747624 268 0.0
lock-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 962004 962328 324 0.0
bss 123465 123465 0 0.0
rodata 97836 97888 52 0.1
text 693596 693864 268 0.0
nrf5340dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 892248 892576 328 0.0
bss 123531 123531 0 0.0
rodata 99264 99320 56 0.1
text 617456 617724 268 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1212328 1212656 328 0.0
bss 119478 119478 0 0.0
rodata 198084 198140 56 0.0
text 740624 740892 268 0.0
pump-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 912920 913248 328 0.0
bss 122142 122142 0 0.0
rodata 73336 73392 56 0.1
text 670336 670604 268 0.0
pump-controller-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 899224 899552 328 0.0
bss 121941 121941 0 0.0
rodata 70072 70128 56 0.1
text 660176 660444 268 0.0
nxp contact k32w0+release (read only) 575628 575628 0 0.0
(read/write) 83140 83140 0 0.0
.bss 67856 67856 0 0.0
.data 2188 2188 0 0.0
.text 575092 575092 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 702980 702980 0 0.0
.bss 71200 71200 0 0.0
.data 2864 2864 0 0.0
.text 589536 589536 0 0.0
light k32w0+release (read only) 609640 609640 0 0.0
(read/write) 82600 82600 0 0.0
.bss 67296 67296 0 0.0
.data 2208 2208 0 0.0
.text 609104 609104 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 794872 794872 0 0.0
.bss 80736 80736 0 0.0
.data 2064 2064 0 0.0
.text 672704 672704 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 832008 832008 0 0.0
(read/write) 1805724 1805724 0 0.0
.bss 198644 198644 0 0.0
.data 2688 2688 0 0.0
.text 1596004 1596004 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 835160 835160 0 0.0
(read/write) 1727628 1727628 0 0.0
.bss 195524 195524 0 0.0
.data 2656 2656 0 0.0
.text 1521060 1521060 0 0.0
light cy8ckit_062s2_43012 (read only) 841880 841880 0 0.0
(read/write) 1646380 1646380 0 0.0
.bss 188988 188988 0 0.0
.data 2472 2472 0 0.0
.text 1446532 1446532 0 0.0
lock cy8ckit_062s2_43012 (read only) 814808 814808 0 0.0
(read/write) 1675044 1675044 0 0.0
.bss 216068 216068 0 0.0
.data 2464 2464 0 0.0
.text 1448124 1448124 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1133164 1133164 0 0.0
.bss 102588 102588 0 0.0
.data 856 856 0 0.0
.text 645544 645544 0 0.0
lock-app qpg6105+debug (read/write) 1093164 1093164 0 0.0
.bss 97260 97260 0 0.0
.data 860 860 0 0.0
.text 605548 605548 0 0.0
stm32 light STM32WB5MM-DK (read/write) 604745 604745 0 0.0
.bss 128436 128436 0 0.0
.data 688 688 0 0.0
.rodata 80532 80532 0 0.0
.text 385344 385344 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 833818 833818 0 0.0
bss 49852 49852 0 0.0
text 624496 624496 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1096896 1096896 0 0.0
bss 101536 101536 0 0.0
text 797896 797896 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1058360 1058360 0 0.0
bss 109984 109984 0 0.0
text 772258 772258 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 913880 913880 0 0.0
bss 92740 92740 0 0.0
text 655738 655738 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 835846 835846 0 0.0
bss 49896 49896 0 0.0
text 626596 626596 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 936796 936796 0 0.0
bss 77508 77508 0 0.0
text 703392 703392 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1090384 1090384 0 0.0
bss 99832 99832 0 0.0
text 793840 793840 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 911092 911092 0 0.0
bss 69176 69176 0 0.0
text 660132 660132 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 932732 932732 0 0.0
bss 92444 92444 0 0.0
text 674774 674774 0 0.0
pump-app tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 833396 833396 0 0.0
bss 58140 58140 0 0.0
text 623596 623596 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 799524 799524 0 0.0
bss 56068 56068 0 0.0
text 598502 598502 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676304 676304 0 0.0
bss 73420 73420 0 0.0
text 462016 462016 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 843570 843570 0 0.0
bss 51524 51524 0 0.0
text 633128 633128 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 858405 858405 0 0.0
bss 59692 59692 0 0.0
text 642086 642086 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 825064 825064 0 0.0
bss 56400 56400 0 0.0
text 618052 618052 0 0.0
window-covering tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 838292 838292 0 0.0
bss 58356 58356 0 0.0
text 626060 626060 0 0.0

LuDuda
LuDuda approved these changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@LuDuda LuDuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mergify mergify bot merged commit be19fc9 into project-chip:master May 6, 2024
65 checks passed
kkasperczyk-no added a commit to kkasperczyk-no/connectedhomeip that referenced this pull request May 8, 2024
@kkasperczyk-no @markaj-nordic @ArekBalysNordic
[nrfconnect] Introduced several improvements for the factory data man…
8948685 
…agement (project-chip#33195)

* [nrfconnect] Added FactoryDataBase to facilitate dynamic
assignments of FactoryDataProvider concrete types to
to the generic pointer.

Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no>

* [nrfconnect] Added non-PM based factory data support

Added support for platforms not built using PM. This commit
includes fixes only firmware implementation and does not include
cmake changes for factory data generation.

Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no>

* [nrfconnect] Improved generation of the factory data

Allow to merge the factory data .hex file with the firmware's .hex
file when partition manager is not available.

* [nrfconnect] Disable External FD if QSPI NOR is not available

We need to have support for factory data when the partition manager
is enabled but there is no support for QSPI external flash.

---------

Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no>
Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no>
Co-authored-by: Marcin Kajor <marcin.kajor@nordicsemi.no>
Co-authored-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
kkasperczyk-no added a commit that referenced this pull request May 8, 2024
@kkasperczyk-no @markaj-nordic @ArekBalysNordic
[nrfconnect] Introduced several improvements for the factory data man…
07e3098 
…agement (#33195)

* [nrfconnect] Added FactoryDataBase to facilitate dynamic
assignments of FactoryDataProvider concrete types to
to the generic pointer.

Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no>

* [nrfconnect] Added non-PM based factory data support

Added support for platforms not built using PM. This commit
includes fixes only firmware implementation and does not include
cmake changes for factory data generation.

Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no>

* [nrfconnect] Improved generation of the factory data

Allow to merge the factory data .hex file with the firmware's .hex
file when partition manager is not available.

* [nrfconnect] Disable External FD if QSPI NOR is not available

We need to have support for factory data when the partition manager
is enabled but there is no support for QSPI external flash.

---------

Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no>
Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no>
Co-authored-by: Marcin Kajor <marcin.kajor@nordicsemi.no>
Co-authored-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
maciejbaczmanski pushed a commit to maciejbaczmanski/connectedhomeip that referenced this pull request Jan 16, 2025
@adigie
Revert "[nrfconnect] Introduced several improvements for the factory …
5035d3f 
…data management (project-chip#33195)"

This reverts commit 07e3098.

Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bauerschwan bauerschwan bauerschwan approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@LuDuda LuDuda Awaiting requested review from LuDuda

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

Assignees
No one assigned
Labels
config nrf connect platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kkasperczyk-no @LuDuda @bauerschwan @markaj-nordic @ArekBalysNordic