-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic Bridge Build Fail [BUG] #26208,with Assign function,it is pos… #27070
Dynamic Bridge Build Fail [BUG] #26208,with Assign function,it is pos… #27070
Conversation
…sible to assign between all clusters in dynamic generated cluster
Jimmy Chen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
PR #27070: Size comparison from 991f367 to 2418123 Increases (15 builds for bl602, bl702, cc32xx, k32w, psoc6, qpg, telink)
Decreases (8 builds for cyw30739, esp32, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems better to use source_set then instead of static_lib.
I will also make a PR to just delete dynamic bridge: it does not seem to be maintained and it has various build failures and will not support some clusters.
Deleting dynamic bridge in #27077 |
we deleted dynamic bridge. I believe this PR can be closed. |
…sible to assign between all clusters in dynamic generated cluster
fix Dynamic Bridge Build Fail [BUG] #26208,
1、add a ValueAssin.cpp in assign lib, without this cpp file, this assign lib will only contains one ValueAssign.h file, and can not be ar to a lib in mac(ubuntu seems does not have
this issue).
2、provide a more cases adapted templates and functions in ValueAssign.h,with a detail description doc in the comment at the beginning of the ValueAssign.h to support
all kinds of assign.