Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chip-tool] Remove examples/chip-tool/commands/pairing/CommissionedLi… #25998

Conversation

vivien-apple
Copy link
Contributor

…stCommand.[h|cpp]

Problem

This code is old and unused since a while. Just remove it.

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

PR #25998: Size comparison from 14ffac0 to 7a95cb3

Full report (1 build for cc32xx)
platform target config section 14ffac0 7a95cb3 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642745 642745 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933099 933099 0 0.0
.debug_aranges 87608 87608 0 0.0
.debug_frame 301328 301328 0 0.0
.debug_info 20302987 20302987 0 0.0
.debug_line 2679748 2679748 0 0.0
.debug_loc 2824679 2824679 0 0.0
.debug_ranges 286200 286200 0 0.0
.debug_str 3039406 3039406 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104289 104289 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377422 377422 0 0.0
.symtab 256768 256768 0 0.0
.text 536336 536336 0 0.0

@vivien-apple vivien-apple force-pushed the ChipTool_RemoveCommissionedListCommand branch from 7a95cb3 to 528d584 Compare April 6, 2023 12:23
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

PR #25998: Size comparison from 14ffac0 to 528d584

Decreases (1 build for cc32xx)
platform target config section 14ffac0 528d584 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20302987 20302986 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 14ffac0 528d584 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642745 642745 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933099 933099 0 0.0
.debug_aranges 87608 87608 0 0.0
.debug_frame 301328 301328 0 0.0
.debug_info 20302987 20302986 -1 -0.0
.debug_line 2679748 2679748 0 0.0
.debug_loc 2824679 2824679 0 0.0
.debug_ranges 286200 286200 0 0.0
.debug_str 3039406 3039406 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104289 104289 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377422 377422 0 0.0
.symtab 256768 256768 0 0.0
.text 536336 536336 0 0.0

@vivien-apple vivien-apple force-pushed the ChipTool_RemoveCommissionedListCommand branch from 528d584 to 2818dd6 Compare April 6, 2023 12:50
@vivien-apple vivien-apple force-pushed the ChipTool_RemoveCommissionedListCommand branch from 2818dd6 to b223c37 Compare April 6, 2023 12:58
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

PR #25998: Size comparison from 14ffac0 to b223c37

Decreases (2 builds for qpg)
platform target config section 14ffac0 b223c37 change % change
qpg lighting-app qpg6105+debug (read/write) 1153440 1153432 -8 -0.0
.text 600536 600528 -8 -0.0
lock-app qpg6105+debug (read/write) 1122048 1122040 -8 -0.0
.text 569148 569140 -8 -0.0
Full report (4 builds for cc32xx, mbed, qpg)
platform target config section 14ffac0 b223c37 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642745 642745 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933099 933099 0 0.0
.debug_aranges 87608 87608 0 0.0
.debug_frame 301328 301328 0 0.0
.debug_info 20302987 20302987 0 0.0
.debug_line 2679748 2679748 0 0.0
.debug_loc 2824679 2824679 0 0.0
.debug_ranges 286200 286200 0 0.0
.debug_str 3039406 3039406 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104289 104289 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377422 377422 0 0.0
.symtab 256768 256768 0 0.0
.text 536336 536336 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2465472 2465472 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1428116 1428116 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1153440 1153432 -8 -0.0
.bss 97404 97404 0 0.0
.data 852 852 0 0.0
.text 600536 600528 -8 -0.0
lock-app qpg6105+debug (read/write) 1122048 1122040 -8 -0.0
.bss 92540 92540 0 0.0
.data 856 856 0 0.0
.text 569148 569140 -8 -0.0

@andy31415 andy31415 enabled auto-merge (squash) April 7, 2023 00:35
@andy31415 andy31415 merged commit 9aed260 into project-chip:master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants