-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up the menus on the M5Stack #25886
Merged
andy31415
merged 2 commits into
project-chip:master
from
mlepage-google:clean-up-m5stack-menus
Mar 30, 2023
Merged
Clean up the menus on the M5Stack #25886
andy31415
merged 2 commits into
project-chip:master
from
mlepage-google:clean-up-m5stack-menus
Mar 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer need screen to demonstrate custom drawing (QR Code screen does this) or non-functional menu items to demonstrate menu scrolling (other menus are now long enough to scroll).
PR #25886: Size comparison from 2aefaa6 to 0c81357 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #25886: Size comparison from 2aefaa6 to eda54b6 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
Mar 29, 2023
andy31415
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer need screen to demonstrate custom drawing (QR Code screen does this) or non-functional menu items to demonstrate menu scrolling (other menus are now long enough to scroll).