Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[matter_yamltests] Generate an error if a cluster definition exists b… #25109

Merged
merged 1 commit into from
Feb 17, 2023
Merged

[matter_yamltests] Generate an error if a cluster definition exists b… #25109

merged 1 commit into from
Feb 17, 2023

Conversation

vivien-apple
Copy link
Contributor

…ut the attribute/event/command can not be found

Problem

When a definition for a given cluster exists but the attribute/command/event does not exists it will be caught at runtime by the adapter.
This PR changes that such that it is caught at parsing time.

@vivien-apple vivien-apple self-assigned this Feb 16, 2023
@pullapprove pullapprove bot requested a review from yunhanw-google February 16, 2023 11:19
@pullapprove pullapprove bot added the scripts label Feb 16, 2023
@vivien-apple vivien-apple force-pushed the YamlTests_ErrorsForUnknownAttributeCommandEvent branch from 8e763f8 to 18608d4 Compare February 16, 2023 11:27
@github-actions
Copy link

PR #25109: Size comparison from 770e39c to 18608d4

Full report (1 build for cc32xx)
platform target config section 770e39c 18608d4 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 641857 641857 0 0.0
(read/write) 204124 204124 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197528 197528 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 931515 931515 0 0.0
.debug_aranges 87432 87432 0 0.0
.debug_frame 300120 300120 0 0.0
.debug_info 20338086 20338086 0 0.0
.debug_line 2657824 2657824 0 0.0
.debug_loc 2790649 2790649 0 0.0
.debug_ranges 281568 281568 0 0.0
.debug_str 3003658 3003658 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105697 105697 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 376514 376514 0 0.0
.symtab 256016 256016 0 0.0
.text 534036 534036 0 0.0

@vivien-apple vivien-apple force-pushed the YamlTests_ErrorsForUnknownAttributeCommandEvent branch from 18608d4 to 4f9c49f Compare February 16, 2023 12:12
@github-actions
Copy link

PR #25109: Size comparison from 770e39c to 4f9c49f

Full report (1 build for cc32xx)
platform target config section 770e39c 4f9c49f change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 641857 641857 0 0.0
(read/write) 204124 204124 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197528 197528 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 931515 931515 0 0.0
.debug_aranges 87432 87432 0 0.0
.debug_frame 300120 300120 0 0.0
.debug_info 20338086 20338086 0 0.0
.debug_line 2657824 2657824 0 0.0
.debug_loc 2790649 2790649 0 0.0
.debug_ranges 281568 281568 0 0.0
.debug_str 3003658 3003658 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105697 105697 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 376514 376514 0 0.0
.symtab 256016 256016 0 0.0
.text 534036 534036 0 0.0

@tehampson tehampson mentioned this pull request Feb 16, 2023
Merged
@vivien-apple
[matter_yamltests] Generates an error if a cluster definition exists …
6b05753 
…but the attribute/event/command can not be found
@vivien-apple vivien-apple force-pushed the YamlTests_ErrorsForUnknownAttributeCommandEvent branch from 4f9c49f to 6b05753 Compare February 16, 2023 17:28
andy31415
andy31415 approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving: my comment can be done as a followup.

@vivien-apple
Copy link
Contributor Author

Approving: my comment can be done as a followup.

Thanks. I have added it to my todo list.

@vivien-apple vivien-apple mentioned this pull request Feb 17, 2023
Open
@vivien-apple vivien-apple merged commit 99821fa into project-chip:master Feb 17, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@vivien-apple
[matter_yamltests] Generates an error if a cluster definition exists …
057718e 
…but the attribute/event/command can not be found (project-chip#25109)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

Assignees

@vivien-apple vivien-apple

Labels
review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivien-apple @andy31415 @bzbarsky-apple