-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tv-casting-app: Fixing issues passing uniqueIDs and Video player caching #24745
tv-casting-app: Fixing issues passing uniqueIDs and Video player caching #24745
Conversation
PR #24745: Size comparison from 27ac945 to 44c0780 Increases (5 builds for cc13x2_26x2, k32w, linux, nrfconnect, qpg)
Decreases (3 builds for psoc6)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
44c0780
to
f53c79d
Compare
f53c79d
to
d94fe94
Compare
PR #24745: Size comparison from 210ae33 to d94fe94 Increases (5 builds for esp32, linux, psoc6, telink)
Decreases (9 builds for bl602, bl702, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@sharadb-amazon could you shed some light on |
This is a software bug, it occurred because we created jniRotatingDeviceIdUniqueIdByteArray on the stack in ConversionUtils.cpp, set it in the outParams and then the stack unwound. This will sometimes lead to the case where the memory allocated gets overwritten. In the fix, we allocate the jniRotatingDeviceIdUniqueIdByteArray on the heap instead. |
ed7a297
to
d94fe94
Compare
PR #24745: Size comparison from 1ba581b to d94fe94 Increases (6 builds for esp32, linux, psoc6, qpg, telink)
Decreases (8 builds for bl602, bl702, cyw30739, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
d94fe94
to
908740d
Compare
PR #24745: Size comparison from b12dbc3 to 908740d Increases (6 builds for bl602, cc13x2_26x2, esp32, linux, telink)
Decreases (7 builds for bl702, cc13x2_26x2, nrfconnect, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…ing (project-chip#24745) * tv-casting-app/android: Updates to how the rotatingDeviceIdUniqueId is passed * tv-casting-app: Fixing persistence logic
…ing (project-chip#24745) * tv-casting-app/android: Updates to how the rotatingDeviceIdUniqueId is passed * tv-casting-app: Fixing persistence logic
…ing (project-chip#24745) * tv-casting-app/android: Updates to how the rotatingDeviceIdUniqueId is passed * tv-casting-app: Fixing persistence logic
Fixes #24744
Change summary
Testing
Tested with the android tv-casting-app running with the linux tv-app