-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chip/barrier-control-cluster.xml by extracting the relevant content from silabs/ha.xml and silabs/types.xml and add missing cluster codes #24675
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:Add_chip_barrier_control_xml
Jan 28, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #24675: Size comparison from 86b064d to 2a73518 Increases above 0.2%:
Increases (3 builds for bl702, k32w)
Full report (15 builds for bl602, bl702, efr32, k32w, mbed, qpg)
|
bzbarsky-apple
requested changes
Jan 27, 2023
src/app/zap-templates/zcl/data-model/chip/barrier-control-cluster.xml
Outdated
Show resolved
Hide resolved
2a73518
to
ba82bf4
Compare
ba82bf4
to
dcfe7a0
Compare
PR #24675: Size comparison from 4820cbd to dcfe7a0 Increases (7 builds for bl602, cyw30739, nrfconnect, qpg, telink)
Decreases (6 builds for bl702, esp32, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 28, 2023
andy31415
approved these changes
Jan 28, 2023
…abs/types.xml and silabs/ha.xml to chip/barrier-control-cluster.xml
dcfe7a0
to
6a56b38
Compare
PR #24675: Size comparison from 7e69c66 to 6a56b38 Increases (7 builds for bl602, bl702, psoc6, telink)
Decreases (9 builds for cc13x2_26x2, cyw30739, esp32, nrfconnect, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…abs/types.xml and silabs/ha.xml to chip/barrier-control-cluster.xml (project-chip#24675)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
BarrierControl
cluster lives insrc/app/zap-templates/zcl/data-model/silabs/ha.xml
andsrc/app/zap-templates/zcl/data-model/silabs/types.xml
and miss some cluster codes. This PR makes it a single file insrc/app/zap-templates/zcl/data-model/chip/barrier-control-cluster.xml
and adds the relevant cluster codes before runningzap_regen_all.py
This is a WIP since I need to see why some code has been removed from
scripts/tools/zap/tests/outputs/all-clusters-app/app-templates/IMClusterCommandHandler.cpp
and CI will likely fails.