-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tv-casting-app: Support for pre-commissioned state to Discovered Video Player Nodes, new AppParams and Read Attribute APIs #23303
Merged
chrisdecenzo
merged 3 commits into
project-chip:master
from
sharadb-amazon:rid-20221020
Oct 24, 2022
Merged
tv-casting-app: Support for pre-commissioned state to Discovered Video Player Nodes, new AppParams and Read Attribute APIs #23303
chrisdecenzo
merged 3 commits into
project-chip:master
from
sharadb-amazon:rid-20221020
Oct 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #23303: Size comparison from 559c7d5 to f222eb1 Increases (5 builds for bl602, cc13x2_26x2, k32w, telink)
Decreases (6 builds for bl702, cc13x2_26x2, nrfconnect, qpg, telink)
Full report (24 builds for bl602, bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
|
chrisdecenzo
approved these changes
Oct 21, 2022
f222eb1
to
ee9e7e9
Compare
PR #23303: Size comparison from a9399de to ee9e7e9 Increases (9 builds for bl602, bl702, psoc6, telink)
Decreases (6 builds for cc13x2_26x2, cyw30739, efr32, esp32, qpg)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23303: Size comparison from a9399de to c0a7447 Increases (2 builds for bl702)
Decreases (2 builds for bl702)
Full report (8 builds for bl702, k32w, mbed, nrfconnect)
|
c0a7447
to
855e71b
Compare
hawk248
approved these changes
Oct 24, 2022
PR #23303: Size comparison from d16182f to 855e71b Increases (1 build for linux)
Decreases (7 builds for bl602, bl702, cyw30739, psoc6, qpg, telink)
Full report (47 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
sharadb-amazon
added a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Nov 11, 2022
…o Player Nodes, new AppParams and Read Attribute APIs (project-chip#23303) * tv-casting-app: Support to pass in the new AppParameters (includes rotatingDeviceId) * tv-casting-app: Adding Read API for ApplicationBasic cluster * tv-casting-app: Exposing pre commissioned state and toConnectableVideoPlayer API
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…o Player Nodes, new AppParams and Read Attribute APIs (project-chip#23303) * tv-casting-app: Support to pass in the new AppParameters (includes rotatingDeviceId) * tv-casting-app: Adding Read API for ApplicationBasic cluster * tv-casting-app: Exposing pre commissioned state and toConnectableVideoPlayer API
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…o Player Nodes, new AppParams and Read Attribute APIs (project-chip#23303) * tv-casting-app: Support to pass in the new AppParameters (includes rotatingDeviceId) * tv-casting-app: Adding Read API for ApplicationBasic cluster * tv-casting-app: Exposing pre commissioned state and toConnectableVideoPlayer API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Summary
This PR provides an API for the Android/iOS/Linux tv-casting-apps to set the rotatingDeviceIdUniqueId.
Testing
Tested the Android/iOS and Linux tv-casting-apps advertise the rotatingDeviceIdUniqueId set by the respective apps and can still be commissioned/send commands. Also, tested that discovery succeeds on all three platforms and the additional pre-commissioned video player state is available as expected.
|
|
| 