Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EFR32]Fix Boot Reason (TC-DGGEN-2.2) #22077

Merged
merged 1 commit into from
Aug 22, 2022
Merged

[EFR32]Fix Boot Reason (TC-DGGEN-2.2) #22077

merged 1 commit into from
Aug 22, 2022

Conversation

jmartinez-silabs
Copy link
Member

@jmartinez-silabs jmartinez-silabs commented Aug 22, 2022 •
edited
Loading

Problem

The boot-reasons always read 0
Read-event doesn't read anything. event isn't created a bootup

Change overview

Fix EFR32 Boot Reason prototype so it matches and overrides the generic one.
The generic one return not_implemented so the event reboot event wasn't created

Replace sl_ot_sys_init by the needed call from things functions. Else efr32MiscInit from ot-efr32 code was being called and 'stealing' the reboot cause from the matter stack (read and clear the register).

Testing

Manual testing
Cause different reboot cause and test with

chip-tool generaldiagnostics read boot-reasons 17635 0
chip-tool generaldiagnostics read-event boot-reason 17635 0

@jmartinez-silabs
Fix GetBootReason prototype so it overrides the generic one, Replace …
3f40a04 
…sl_ot_sys_init by manual call. OT efr32MiscInit was 'stealing' the reboot cause from the matter stack
@jmartinez-silabs
Copy link
Member Author

SVE request for cherry-pick : EFR32 platform fix to pass TC-DGGEN-2.2

@github-actions
Copy link

github-actions bot commented Aug 22, 2022 •
edited
Loading

PR #22077: Size comparison from 585a53a to 3f40a04

Increases (7 builds for cc13x2_26x2, efr32, telink)
platform target config section 585a53a 3f40a04 change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read/write) 157728 157736 8 0.0
efr32 lighting-app BRD4161A (read/write) 1104716 1104724 8 0.0
.text 969052 969068 16 0.0
BRD4161A+rpc (read/write) 967916 967924 8 0.0
.text 818068 818084 16 0.0
BRD4161A+rs911x (read/write) 997968 998016 48 0.0
.text 828900 828948 48 0.0
lock-app BRD4161A+wf200 (read/write) 1147332 1147380 48 0.0
.text 995080 995128 48 0.0
window-app BRD4161A (read/write) 1096044 1096052 8 0.0
.text 958916 958932 16 0.0
telink light-switch-app tlsr9518adk80d text 571320 571322 2 0.0
Decreases (10 builds for bl602, cc13x2_26x2, efr32, esp32, nrfconnect, psoc6, telink)
platform target config section 585a53a 3f40a04 change % change
bl602 lighting-app bl602+rpc (read/write) 1429386 1429378 -8 -0.0
.text 1082816 1082812 -4 -0.0
cc13x2_26x2 pump-app LP_CC2652R7 (read only) 684775 684767 -8 -0.0
.text 594332 594324 -8 -0.0
efr32 lighting-app BRD4161A .bss 133572 133564 -8 -0.0
BRD4161A+rpc .bss 147572 147564 -8 -0.0
window-app BRD4161A .bss 135012 135004 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1031270 1031268 -2 -0.0
.flash.text 1031270 1031268 -2 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 803088 803084 -4 -0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26379890 26379889 -1 -0.0
light cy8ckit_062s2_43012 .debug_info 21844447 21844446 -1 -0.0
telink lighting-app tlsr9518adk80d text 589412 589410 -2 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
platform target config section 585a53a 3f40a04 change % change
bl602 lighting-app bl602 (read/write) 1383874 1383874 0 0.0
.bss 120258 120258 0 0.0
.data 4480 4480 0 0.0
.text 1051056 1051056 0 0.0
bl602+rpc (read/write) 1429386 1429378 -8 -0.0
.bss 127698 127698 0 0.0
.data 4600 4600 0 0.0
.text 1082816 1082812 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 673035 673035 0 0.0
(read/write) 178460 178460 0 0.0
.bss 74388 74388 0 0.0
.data 3372 3372 0 0.0
.rodata 88835 88835 0 0.0
.text 583884 583884 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637755 637755 0 0.0
(read/write) 157948 157948 0 0.0
.bss 73660 73660 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559452 559452 0 0.0
lock-ftd LP_CC2652R7 (read only) 674103 674103 0 0.0
(read/write) 167592 167592 0 0.0
.bss 71476 71476 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596952 596952 0 0.0
lock-mtd LP_CC2652R7 (read only) 656839 656839 0 0.0
(read/write) 180544 180544 0 0.0
.bss 67164 67164 0 0.0
.data 3296 3296 0 0.0
.rodata 101759 101759 0 0.0
.text 554600 554600 0 0.0
pump-app LP_CC2652R7 (read only) 684775 684767 -8 -0.0
(read/write) 157728 157736 8 0.0
.bss 71516 71516 0 0.0
.data 3296 3296 0 0.0
.rodata 89959 89959 0 0.0
.text 594332 594324 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 669267 669267 0 0.0
(read/write) 173356 173356 0 0.0
.bss 71636 71636 0 0.0
.data 3292 3292 0 0.0
.rodata 85515 85515 0 0.0
.text 583272 583272 0 0.0
shell LP_CC2652R7 (read only) 665718 665718 0 0.0
(read/write) 181296 181296 0 0.0
.bss 76708 76708 0 0.0
.data 3376 3376 0 0.0
.rodata 85782 85782 0 0.0
.text 579620 579620 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586626 586626 0 0.0
.app_xip_area 463292 463292 0 0.0
.bss 65768 65768 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592426 592426 0 0.0
.app_xip_area 464308 464308 0 0.0
.bss 70552 70552 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599554 599554 0 0.0
.app_xip_area 476940 476940 0 0.0
.bss 65080 65080 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1104716 1104724 8 0.0
.bss 133572 133564 -8 -0.0
.data 2072 2072 0 0.0
.text 969052 969068 16 0.0
BRD4161A+rpc (read/write) 967916 967924 8 0.0
.bss 147572 147564 -8 -0.0
.data 2252 2252 0 0.0
.text 818068 818084 16 0.0
BRD4161A+rs911x (read/write) 997968 998016 48 0.0
.bss 166992 166992 0 0.0
.data 2056 2056 0 0.0
.text 828900 828948 48 0.0
lock-app BRD4161A+wf200 (read/write) 1147332 1147380 48 0.0
.bss 150168 150168 0 0.0
.data 2064 2064 0 0.0
.text 995080 995128 48 0.0
window-app BRD4161A (read/write) 1096044 1096052 8 0.0
.bss 135012 135004 -8 -0.0
.data 2096 2096 0 0.0
.text 958916 958932 16 0.0
esp32 all-clusters-app c3devkit (read only) 1031270 1031268 -2 -0.0
(read/write) 1489610 1489610 0 0.0
.dram0.bss 71136 71136 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 218440 218440 0 0.0
.flash.text 1031270 1031268 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1084387 1084387 0 0.0
(read/write) 491544 491544 0 0.0
.dram0.bss 76640 76640 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 248764 248764 0 0.0
.flash.text 1079003 1079003 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w0+release (read/write) 646676 646676 0 0.0
.bss 70400 70400 0 0.0
.data 2068 2068 0 0.0
.text 571480 571480 0 0.0
lock k32w0+release (read/write) 704212 704212 0 0.0
.bss 70864 70864 0 0.0
.data 2076 2076 0 0.0
.text 628544 628544 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10259132 10259132 0 0.0
(read/write) 699137 699137 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 643824 643824 0 0.0
.dynamic 560 560 0 0.0
.got 13784 13784 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493564 493564 0 0.0
.text 8127428 8127428 0 0.0
thermostat-no-ble arm64 (read only) 2357300 2357300 0 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140620 140620 0 0.0
.text 1978960 1978960 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454328 2454328 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1416972 1416972 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180619 1180619 0 0.0
bss 143737 143737 0 0.0
rodata 143356 143356 0 0.0
text 814680 814680 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159815 1159815 0 0.0
bss 142964 142964 0 0.0
rodata 134944 134944 0 0.0
text 803088 803084 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 881000 881000 0 0.0
(read/write) 1700996 1700996 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 149688 149688 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1217459 1217459 0 0.0
.debug_aranges 111528 111528 0 0.0
.debug_frame 372352 372352 0 0.0
.debug_info 26643195 26643195 0 0.0
.debug_line 3646641 3646641 0 0.0
.debug_loc 3562039 3562039 0 0.0
.debug_ranges 336576 336576 0 0.0
.debug_str 3393852 3393852 0 0.0
.heap 881000 881000 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569346 569346 0 0.0
.symtab 420416 420416 0 0.0
.text 0 0 0 0.0
1540264 1540264 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 881736 881736 0 0.0
(read/write) 1644204 1644204 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 148952 148952 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1209298 1209298 0 0.0
.debug_aranges 111000 111000 0 0.0
.debug_frame 375432 375432 0 0.0
.debug_info 26379890 26379889 -1 -0.0
.debug_line 3667045 3667045 0 0.0
.debug_loc 3549676 3549676 0 0.0
.debug_ranges 335192 335192 0 0.0
.debug_str 3382841 3382841 0 0.0
.heap 881736 881736 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533820 533820 0 0.0
.symtab 407008 407008 0 0.0
.text 1484208 1484208 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 890080 890080 0 0.0
(read/write) 1561436 1561436 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 140816 140816 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2448 2448 0 0.0
.debug_abbrev 1043971 1043971 0 0.0
.debug_aranges 103168 103168 0 0.0
.debug_frame 345676 345676 0 0.0
.debug_info 21844447 21844446 -1 -0.0
.debug_line 3238223 3238223 0 0.0
.debug_loc 3249207 3249207 0 0.0
.debug_ranges 301032 301032 0 0.0
.debug_str 3188935 3188935 0 0.0
.heap 890080 890080 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 467101 467101 0 0.0
.symtab 374064 374064 0 0.0
.text 1409784 1409784 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 885584 885584 0 0.0
(read/write) 1598724 1598724 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 145296 145296 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1051147 1051147 0 0.0
.debug_aranges 103840 103840 0 0.0
.debug_frame 348500 348500 0 0.0
.debug_info 22199615 22199615 0 0.0
.debug_line 3246909 3246909 0 0.0
.debug_loc 3289327 3289327 0 0.0
.debug_ranges 304448 304448 0 0.0
.debug_str 3216366 3216366 0 0.0
.heap 885584 885584 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473342 473342 0 0.0
.symtab 377248 377248 0 0.0
.text 1442576 1442576 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808744 808744 0 0.0
bss 71448 71448 0 0.0
noinit 43488 43488 0 0.0
text 571320 571322 2 0.0
lighting-app tlsr9518adk80d (read/write) 830680 830680 0 0.0
bss 72304 72304 0 0.0
noinit 43488 43488 0 0.0
text 589412 589410 -2 -0.0

@jmartinez-silabs jmartinez-silabs enabled auto-merge (squash) August 22, 2022 18:57
@jmartinez-silabs jmartinez-silabs merged commit f68b948 into project-chip:master Aug 22, 2022
github-actions bot pushed a commit that referenced this pull request Aug 22, 2022
@jmartinez-silabs @web-flow
Fix GetBootReason prototype so it overrides the generic one, Replace …
5646f1e 
…sl_ot_sys_init by manual call. OT efr32MiscInit was 'stealing' the reboot cause from the matter stack (#22077)
andy31415 added a commit that referenced this pull request Aug 24, 2022
@woody-apple @jmartinez-silabs @andy31415
Fix GetBootReason prototype so it overrides the generic one, Replace …
50b6c13 
…sl_ot_sys_init by manual call. OT efr32MiscInit was 'stealing' the reboot cause from the matter stack (#22077) (#22081)

Co-authored-by: jmartinez-silabs <67972863+jmartinez-silabs@users.noreply.github.com>
Co-authored-by: Andrei Litvin <andy314@gmail.com>
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@jmartinez-silabs @isiu-apple
Fix GetBootReason prototype so it overrides the generic one, Replace …
89a9f88 
…sl_ot_sys_init by manual call. OT efr32MiscInit was 'stealing' the reboot cause from the matter stack (project-chip#22077)
@jmartinez-silabs jmartinez-silabs deleted the fix_boot_reason branch February 2, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@andy31415 andy31415 Awaiting requested review from andy31415

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

Assignees
No one assigned
Labels
efr32 examples platform request sve review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmartinez-silabs @andy31415 @jepenven-silabs