Use SupportedLocalesIterator to read ReadSupportedLocales from Device… #16950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs and
lazarkov
pullapprove
bot
requested review from
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
woody-apple
approved these changes
Apr 1, 2022
|
PR #16950: Size comparison from 37094b5 to 1f8e6b5 Increases above 0.2%:
Increases (18 builds for cc13x2_26x2, esp32, linux, nrfconnect)
Decreases (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Apr 2, 2022
yunhanw-google
approved these changes
Apr 4, 2022
saurabhst
approved these changes
Apr 4, 2022
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…InfoProvider
Problem
What is being fixed? Examples:
Same as Use iteration pattern to get the fixed user label list #16861, vendor found it is difficult to implement the ReadSupportedLocales with current API in PlatformMgr.
Currently, API GetSupportedLocales returns a AttributeList with a list of CharSpan which need us pre-allocate a buffer to store those locales loaded from the persistent storage, and we need to keep this buffer after function _GetSupportedLocales returns. But it is hard to know how to release this buffer since different platforms use different mechanism to allocate the memory.
Need to figure out a way so that vendor do not need to pre-allocate memory to store the supported locales list.
Change overview
Testing
How was this tested? (at least one bullet point required)