-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avahi - Don't error when receiving an ipv4 address #15976
Merged
andy31415
merged 1 commit into
project-chip:master
from
cecille:avahi_ipv4_rejection_issue
Mar 9, 2022
Merged
Avahi - Don't error when receiving an ipv4 address #15976
andy31415
merged 1 commit into
project-chip:master
from
cecille:avahi_ipv4_rejection_issue
Mar 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Receiving an ipv4 address isn't an error, we should just ignore it if we don't support it.
PR #15976: Size comparison from 949bd86 to 4bb9645 Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Mar 9, 2022
andy31415
approved these changes
Mar 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, however based on my tests I had avahi only return an address once, so if we do not error out and continue, we may never get the ipv6 and just time out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Avahi will throw an error if it gets an A record and doesn't support IPV4.
Receiving an ipv4 address isn't an error, we should just ignore it
if we don't support it.
Change overview
Changes address error to check for any useable address.
Testing
Tested with 1p device that returns both ipv4 and ipv6. Saw ignore message, but got responses.