Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC: Console improvements. #15916

Merged
merged 1 commit into from
Mar 7, 2022
Merged

RPC: Console improvements. #15916

merged 1 commit into from
Mar 7, 2022

Conversation

rgoliver
Copy link

@rgoliver rgoliver commented Mar 7, 2022

Problem

The RPC console is used for getting device logs and sending RPC commands to the device, cleanup the console including handling more device log types, and adding some helpful plugins for getting device info.

Change overview

  • Add chip device toolbar for quickly viewing device info including; VID, PID, SN, Pairing code/discriminator, fabric, node, pair state
  • Add raw serial logger for debugging serial communication errors.
  • Decode EFR32 log lines.
  • Decode NFR32 log lines.
  • Decode NXP log lines.
  • Add raw logger for log streams which are not HDLC encoded.
  • Add a helper scripts class, which currently just has a script to read the descriptor cluster.

Testing

Built the console and tested with RPC builds of the m5stack all clusters app.

RPC: Console improvements.
0c5cf3a 
- Add chip device toolbar for viewing device info including;
  VID, PID, SN, Pairing code/discrimator, fabric, node, pair state
- Add raw serial logger for debugging serial communication.
- Decode EFR32 log lines.
- Decode NFR32 log lines.
- Decode NXP log lines.
- Add raw logger for log streams which are not HDLC encoded.
- Add a helper scripts class, which currently just has a script to
  read the descriptor cluster.
@github-actions
Copy link

github-actions bot commented Mar 7, 2022 •
edited
Loading

PR #15916: Size comparison from 0b10bc8 to 0c5cf3a

Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 0b10bc8 0c5cf3a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601706 601706 0 0.0
.app_xip_area 506240 506240 0 0.0
.bss 78148 78148 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559626 559626 0 0.0
.app_xip_area 465696 465696 0 0.0
.bss 76652 76652 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581822 581822 0 0.0
.app_xip_area 478212 478212 0 0.0
.bss 85980 85980 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920804 920804 0 0.0
(read/write) 128848 128848 0 0.0
.bss 126768 126768 0 0.0
.data 2080 2080 0 0.0
.text 920796 920796 0 0.0
BRD4161A+rpc (read only) 949640 949640 0 0.0
(read/write) 144808 144808 0 0.0
.bss 142544 142544 0 0.0
.data 2260 2260 0 0.0
.text 949632 949632 0 0.0
lock-app BRD4161A+wf200 (read only) 988724 988724 0 0.0
(read/write) 120368 120368 0 0.0
.bss 118436 118436 0 0.0
.data 1932 1932 0 0.0
.text 988716 988716 0 0.0
window-app BRD4161A (read only) 853800 853800 0 0.0
(read/write) 126840 126840 0 0.0
.bss 124912 124912 0 0.0
.data 1924 1924 0 0.0
.text 853792 853792 0 0.0
esp32 all-clusters-app c3devkit (read only) 957332 957332 0 0.0
(read/write) 1393586 1393586 0 0.0
.dram0.bss 63432 63432 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197000 197000 0 0.0
.flash.text 957332 957332 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012175 1012175 0 0.0
(read/write) 460692 460692 0 0.0
.dram0.bss 68960 68960 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225816 225816 0 0.0
.flash.text 1006791 1006791 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694616 694616 0 0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 609148 609148 0 0.0
lock k32w061+release (read/write) 696204 696204 0 0.0
.bss 77672 77672 0 0.0
.data 1972 1972 0 0.0
.text 610760 610760 0 0.0
linux all-clusters-app debug (read only) 2426113 2426113 0 0.0
(read/write) 145760 145760 0 0.0
.bss 60128 60128 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78504 78504 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205445 205445 0 0.0
.text 2057538 2057538 0 0.0
bridge-app debug+rpc (read only) 1730853 1730853 0 0.0
(read/write) 92720 92720 0 0.0
.bss 47432 47432 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38144 38144 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141652 141652 0 0.0
.text 1473061 1473061 0 0.0
chip-tool debug (read only) 9748309 9748309 0 0.0
(read/write) 338232 338232 0 0.0
.bss 25544 25544 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 305504 305504 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 509748 509748 0 0.0
.text 8500085 8500085 0 0.0
chip-tool-ipv6only arm64 (read only) 9421588 9421588 0 0.0
(read/write) 453761 453761 0 0.0
.bss 43841 43841 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 350648 350648 0 0.0
.dynamic 560 560 0 0.0
.got 54272 54272 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 485580 485580 0 0.0
.text 7933300 7933300 0 0.0
door-lock-app debug (read only) 1945209 1945209 0 0.0
(read/write) 119136 119136 0 0.0
.bss 50432 50432 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62264 62264 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173596 173596 0 0.0
.text 1622802 1622802 0 0.0
lighting-app debug+rpc (read only) 2077521 2077521 0 0.0
(read/write) 124536 124536 0 0.0
.bss 51296 51296 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 66184 66184 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 165788 165788 0 0.0
.text 1755954 1755954 0 0.0
ota-provider-app debug (read only) 1878065 1878065 0 0.0
(read/write) 114768 114768 0 0.0
.bss 50240 50240 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57544 57544 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158835 158835 0 0.0
.text 1568338 1568338 0 0.0
ota-requestor-app debug (read only) 1900129 1900129 0 0.0
(read/write) 117512 117512 0 0.0
.bss 51296 51296 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 59256 59256 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 154124 154124 0 0.0
.text 1595778 1595778 0 0.0
shell debug (read only) 2392897 2392897 0 0.0
(read/write) 149976 149976 0 0.0
.bss 70216 70216 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73232 73232 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205394 205394 0 0.0
.text 2030594 2030594 0 0.0
thermostat-no-ble arm64 (read only) 2174164 2174164 0 0.0
(read/write) 148609 148609 0 0.0
.bss 65201 65201 0 0.0
.data 1080 1080 0 0.0
.data.rel.ro 75136 75136 0 0.0
.dynamic 560 560 0 0.0
.got 4224 4224 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132948 132948 0 0.0
.text 1822592 1822592 0 0.0
tv-app debug (read only) 2617689 2617689 0 0.0
(read/write) 250872 250872 0 0.0
.bss 167936 167936 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73704 73704 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199485 199485 0 0.0
.text 2243922 2243922 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350468 2350468 0 0.0
.bss 186084 186084 0 0.0
.data 5800 5800 0 0.0
.text 1313068 1313068 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151579 1151579 0 0.0
bss 146792 146792 0 0.0
rodata 144276 144276 0 0.0
text 785316 785316 0 0.0
p6 all-clusters-app default (read/write) 2493944 2493944 0 0.0
.bss 119504 119504 0 0.0
.data 2696 2696 0 0.0
.text 1452208 1452208 0 0.0
light-app default (read/write) 2397408 2397408 0 0.0
.bss 112976 112976 0 0.0
.data 2544 2544 0 0.0
.text 1355672 1355672 0 0.0
lock-app default (read/write) 2360824 2360824 0 0.0
.bss 112720 112720 0 0.0
.data 2504 2504 0 0.0
.text 1319088 1319088 0 0.0
qpg lighting-app qpg6105+debug (read only) 603860 603860 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91080 91080 0 0.0
.data 1164 1164 0 0.0
.text 598540 598540 0 0.0
lock-app qpg6105+debug (read only) 569472 569472 0 0.0
(read/write) 146936 146936 0 0.0
.bss 91088 91088 0 0.0
.data 1116 1116 0 0.0
.text 564152 564152 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888718 888718 0 0.0
bss 86928 86928 0 0.0
noinit 37160 37160 0 0.0
text 628108 628108 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking tooling updates

@woody-apple woody-apple merged commit c0373bb into project-chip:master Mar 7, 2022
mykrupp referenced this pull request in mykrupp/connectedhomeip-1 Mar 8, 2022
@mykrupp
RPC: Console improvements. (#15916)
1cd7ba1 
- Add chip device toolbar for viewing device info including;
  VID, PID, SN, Pairing code/discrimator, fabric, node, pair state
- Add raw serial logger for debugging serial communication.
- Decode EFR32 log lines.
- Decode NFR32 log lines.
- Decode NXP log lines.
- Add raw logger for log streams which are not HDLC encoded.
- Add a helper scripts class, which currently just has a script to
  read the descriptor cluster.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgoliver @woody-apple