Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CLI tab-to-autocomplete ability and implement for nrfconnect #13630

Merged
merged 6 commits into from
Jan 27, 2022
Merged

add CLI tab-to-autocomplete ability and implement for nrfconnect #13630

merged 6 commits into from
Jan 27, 2022

Conversation

lmpprk
Copy link
Contributor

@lmpprk lmpprk commented Jan 17, 2022 •
edited
Loading

Problem

Change overview

  • Require command prefix/path as argument at time of command registration (e.g. "dns" is prefix for "dns resolve" and "dns browse")
  • Add Engine::GetCmdCompletion to provide command completion based on command prefixes
  • Implement the tab autocompletion for nRF Connect platform

Testing

Build and tested manually with

nRF52840dk and nRF52840dongle with lighting-app example
cli-tab

updated Jan 26: I couldn't get the esp32 implementation to work properly after addressing review comments, so removing the esp32 implementation from this PR and will do another PR later once fixed.

@github-actions
Copy link

github-actions bot commented Jan 17, 2022 •
edited
Loading

PR #13630: Size comparison from 9109dff to a9b5af9

Increases above 0.2%:

platform target config section 9109dff a9b5af9 change % change
linux thermostat-no-ble arm64 .got 4048 4064 16 0.4
mbed shell CY8CPROTO_062_4343W+release .data 4864 4888 24 0.5
nrfconnect shell nrf52840dk_nrf52840 (read/write) 798655 800583 1928 0.2
text 533992 536496 2504 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 711470 713398 1928 0.3
text 451668 454168 2500 0.6
telink lighting-app tlsr9518adk80d text 587748 590162 2414 0.4
Increases (6 builds for esp32, linux, mbed, nrfconnect, telink)
platform target config section 9109dff a9b5af9 change % change
esp32 all-clusters-app m5stack (read only) 960883 962375 1492 0.2
.flash.rodata 207672 207772 100 0.0
.flash.text 955499 956991 1492 0.2
linux thermostat-no-ble arm64 (read only) 2042108 2046220 4112 0.2
.got 4048 4064 16 0.4
.text 1697632 1701696 4064 0.2
mbed shell CY8CPROTO_062_4343W+release (read/write) 2054464 2056200 1736 0.1
.data 4864 4888 24 0.5
.text 1017064 1018800 1736 0.2
nrfconnect shell nrf52840dk_nrf52840 (read/write) 798655 800583 1928 0.2
rodata 78388 78396 8 0.0
text 533992 536496 2504 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 711470 713398 1928 0.3
rodata 72688 72696 8 0.0
text 451668 454168 2500 0.6
telink lighting-app tlsr9518adk80d (read/write) 840778 842798 2020 0.2
text 587748 590162 2414 0.4
Decreases (6 builds for esp32, linux, mbed, nrfconnect, telink)
platform target config section 9109dff a9b5af9 change % change
esp32 all-clusters-app m5stack (read/write) 448840 448036 -804 -0.2
.dram0.bss 74976 74072 -904 -1.2
linux thermostat-no-ble arm64 (read/write) 145969 144385 -1584 -1.1
.bss 65089 63489 -1600 -2.5
mbed shell CY8CPROTO_062_4343W+release .bss 156876 156036 -840 -0.5
nrfconnect shell nrf52840dk_nrf52840 bss 109776 109156 -620 -0.6
nrf5340dk_nrf5340_cpuapp bss 107664 107044 -620 -0.6
telink lighting-app tlsr9518adk80d bss 87316 86904 -412 -0.5
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 9109dff a9b5af9 change % change
efr32 lighting-app BRD4161A (read only) 834852 834852 0 0.0
(read/write) 127628 127628 0 0.0
.bss 125744 125744 0 0.0
.data 1884 1884 0 0.0
.text 834844 834844 0 0.0
BRD4161A+rpc (read only) 822232 822232 0 0.0
(read/write) 144288 144288 0 0.0
.bss 142304 142304 0 0.0
.data 1984 1984 0 0.0
.text 822224 822224 0 0.0
window-app BRD4161A (read only) 805424 805424 0 0.0
(read/write) 126320 126320 0 0.0
.bss 124480 124480 0 0.0
.data 1836 1836 0 0.0
.text 805416 805416 0 0.0
esp32 all-clusters-app c3devkit (read only) 912094 912094 0 0.0
(read/write) 1316682 1316682 0 0.0
.dram0.bss 70520 70520 0 0.0
.dram0.data 14284 14284 0 0.0
.flash.rodata 178384 178384 0 0.0
.flash.text 912094 912094 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 960883 962375 1492 0.2
(read/write) 448840 448036 -804 -0.2
.dram0.bss 74976 74072 -904 -1.2
.dram0.data 34064 34064 0 0.0
.flash.rodata 207672 207772 100 0.0
.flash.text 955499 956991 1492 0.2
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 659064 659064 0 0.0
.bss 77136 77136 0 0.0
.data 1852 1852 0 0.0
.text 574276 574276 0 0.0
lock k32w061+release (read/write) 661796 661796 0 0.0
.bss 77432 77432 0 0.0
.data 1872 1872 0 0.0
.text 576692 576692 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8042100 8042100 0 0.0
(read/write) 370641 370641 0 0.0
.bss 55217 55217 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 245856 245856 0 0.0
.dynamic 560 560 0 0.0
.got 64776 64776 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 419420 419420 0 0.0
.text 6833684 6833684 0 0.0
thermostat-no-ble arm64 (read only) 2042108 2046220 4112 0.2
(read/write) 145969 144385 -1584 -1.1
.bss 65089 63489 -1600 -2.5
.data 880 880 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4048 4064 16 0.4
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129884 129884 0 0.0
.text 1697632 1701696 4064 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349856 2349856 0 0.0
.bss 189220 189220 0 0.0
.data 5320 5320 0 0.0
.text 1312432 1312432 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334504 2334504 0 0.0
.bss 180760 180760 0 0.0
.data 5568 5568 0 0.0
.text 1297104 1297104 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304848 2304848 0 0.0
.bss 179768 179768 0 0.0
.data 5544 5544 0 0.0
.text 1267448 1267448 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054464 2056200 1736 0.1
.bss 156876 156036 -840 -0.5
.data 4864 4888 24 0.5
.text 1017064 1018800 1736 0.2
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 943403 943403 0 0.0
bss 119628 119628 0 0.0
rodata 108824 108824 0 0.0
text 637376 637376 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 928883 928883 0 0.0
bss 116672 116672 0 0.0
rodata 101272 101272 0 0.0
text 632772 632772 0 0.0
nrf52840dongle_nrf52840 (read/write) 994079 994079 0 0.0
bss 122472 122472 0 0.0
rodata 113576 113576 0 0.0
text 669576 669576 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853242 853242 0 0.0
bss 116416 116416 0 0.0
rodata 101996 101996 0 0.0
text 554300 554300 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912763 912763 0 0.0
bss 118784 118784 0 0.0
rodata 103792 103792 0 0.0
text 612824 612824 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822830 822830 0 0.0
bss 115600 115600 0 0.0
rodata 97016 97016 0 0.0
text 529784 529784 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915627 915627 0 0.0
bss 118548 118548 0 0.0
rodata 104152 104152 0 0.0
text 615480 615480 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910715 910715 0 0.0
bss 118572 118572 0 0.0
rodata 103264 103264 0 0.0
text 611404 611404 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798655 800583 1928 0.2
bss 109776 109156 -620 -0.6
rodata 78388 78396 8 0.0
text 533992 536496 2504 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 711470 713398 1928 0.3
bss 107664 107044 -620 -0.6
rodata 72688 72696 8 0.0
text 451668 454168 2500 0.6
p6 all-clusters-app default (read/write) 2404744 2404744 0 0.0
.bss 117556 117556 0 0.0
.data 2600 2600 0 0.0
.text 1363008 1363008 0 0.0
light-app default (read/write) 2330048 2330048 0 0.0
.bss 106128 106128 0 0.0
.data 2392 2392 0 0.0
.text 1288312 1288312 0 0.0
lock-app default (read/write) 2299072 2299072 0 0.0
.bss 104976 104976 0 0.0
.data 2344 2344 0 0.0
.text 1257336 1257336 0 0.0
qpg lighting-app qpg6105+debug (read only) 565072 565072 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89960 89960 0 0.0
.data 1048 1048 0 0.0
.text 559752 559752 0 0.0
lock-app qpg6105+debug (read only) 515484 515484 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88584 88584 0 0.0
.data 972 972 0 0.0
.text 510164 510164 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 840778 842798 2020 0.2
bss 87316 86904 -412 -0.5
noinit 37160 37160 0 0.0
text 587748 590162 2414 0.4

@lmpprk lmpprk force-pushed the shell-cmd-suggestion branch from a9b5af9 to 69a9ee8 Compare January 18, 2022 07:48
@github-actions
Copy link

github-actions bot commented Jan 18, 2022 •
edited
Loading

PR #13630: Size comparison from d611c63 to 69a9ee8

Increases above 0.2%:

platform target config section d611c63 69a9ee8 change % change
linux thermostat-no-ble arm64 .got 4048 4064 16 0.4
mbed shell CY8CPROTO_062_4343W+release .data 4864 4888 24 0.5
nrfconnect shell nrf52840dk_nrf52840 (read/write) 798655 800599 1944 0.2
text 533992 536504 2512 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 711470 713398 1928 0.3
text 451668 454180 2512 0.6
telink lighting-app tlsr9518adk80d text 587790 590216 2426 0.4
Increases (5 builds for linux, mbed, nrfconnect, telink)
platform target config section d611c63 69a9ee8 change % change
linux thermostat-no-ble arm64 (read only) 2042812 2046924 4112 0.2
.got 4048 4064 16 0.4
.text 1698336 1702400 4064 0.2
mbed shell CY8CPROTO_062_4343W+release (read/write) 2054464 2056200 1736 0.1
.data 4864 4888 24 0.5
.text 1017064 1018800 1736 0.2
nrfconnect shell nrf52840dk_nrf52840 (read/write) 798655 800599 1944 0.2
rodata 78388 78396 8 0.0
text 533992 536504 2512 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 711470 713398 1928 0.3
rodata 72688 72696 8 0.0
text 451668 454180 2512 0.6
telink lighting-app tlsr9518adk80d (read/write) 840826 842854 2028 0.2
text 587790 590216 2426 0.4
Decreases (5 builds for linux, mbed, nrfconnect, telink)
platform target config section d611c63 69a9ee8 change % change
linux thermostat-no-ble arm64 (read/write) 145969 144385 -1584 -1.1
.bss 65089 63489 -1600 -2.5
mbed shell CY8CPROTO_062_4343W+release .bss 156876 156036 -840 -0.5
nrfconnect shell nrf52840dk_nrf52840 bss 109776 109156 -620 -0.6
nrf5340dk_nrf5340_cpuapp bss 107664 107044 -620 -0.6
telink lighting-app tlsr9518adk80d bss 87316 86904 -412 -0.5
Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d611c63 69a9ee8 change % change
efr32 lighting-app BRD4161A (read only) 834868 834868 0 0.0
(read/write) 127628 127628 0 0.0
.bss 125744 125744 0 0.0
.data 1884 1884 0 0.0
.text 834860 834860 0 0.0
BRD4161A+rpc (read only) 822264 822264 0 0.0
(read/write) 144288 144288 0 0.0
.bss 142304 142304 0 0.0
.data 1984 1984 0 0.0
.text 822256 822256 0 0.0
window-app BRD4161A (read only) 805456 805456 0 0.0
(read/write) 126320 126320 0 0.0
.bss 124480 124480 0 0.0
.data 1836 1836 0 0.0
.text 805448 805448 0 0.0
k32w light k32w061+release (read/write) 659080 659080 0 0.0
.bss 77136 77136 0 0.0
.data 1852 1852 0 0.0
.text 574292 574292 0 0.0
lock k32w061+release (read/write) 661812 661812 0 0.0
.bss 77432 77432 0 0.0
.data 1872 1872 0 0.0
.text 576708 576708 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8049492 8049492 0 0.0
(read/write) 370641 370641 0 0.0
.bss 55217 55217 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 245856 245856 0 0.0
.dynamic 560 560 0 0.0
.got 64776 64776 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 419420 419420 0 0.0
.text 6841076 6841076 0 0.0
thermostat-no-ble arm64 (read only) 2042812 2046924 4112 0.2
(read/write) 145969 144385 -1584 -1.1
.bss 65089 63489 -1600 -2.5
.data 880 880 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4048 4064 16 0.4
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129884 129884 0 0.0
.text 1698336 1702400 4064 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350112 2350112 0 0.0
.bss 189220 189220 0 0.0
.data 5320 5320 0 0.0
.text 1312688 1312688 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334568 2334568 0 0.0
.bss 180760 180760 0 0.0
.data 5568 5568 0 0.0
.text 1297168 1297168 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304912 2304912 0 0.0
.bss 179768 179768 0 0.0
.data 5544 5544 0 0.0
.text 1267512 1267512 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054464 2056200 1736 0.1
.bss 156876 156036 -840 -0.5
.data 4864 4888 24 0.5
.text 1017064 1018800 1736 0.2
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 943419 943419 0 0.0
bss 119628 119628 0 0.0
rodata 108824 108824 0 0.0
text 637388 637388 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 928899 928899 0 0.0
bss 116672 116672 0 0.0
rodata 101272 101272 0 0.0
text 632784 632784 0 0.0
nrf52840dongle_nrf52840 (read/write) 994095 994095 0 0.0
bss 122472 122472 0 0.0
rodata 113576 113576 0 0.0
text 669588 669588 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 853242 853242 0 0.0
bss 116416 116416 0 0.0
rodata 101996 101996 0 0.0
text 554312 554312 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912779 912779 0 0.0
bss 118784 118784 0 0.0
rodata 103792 103792 0 0.0
text 612836 612836 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822846 822846 0 0.0
bss 115600 115600 0 0.0
rodata 97016 97016 0 0.0
text 529796 529796 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915643 915643 0 0.0
bss 118548 118548 0 0.0
rodata 104152 104152 0 0.0
text 615492 615492 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910715 910715 0 0.0
bss 118572 118572 0 0.0
rodata 103264 103264 0 0.0
text 611416 611416 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798655 800599 1944 0.2
bss 109776 109156 -620 -0.6
rodata 78388 78396 8 0.0
text 533992 536504 2512 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 711470 713398 1928 0.3
bss 107664 107044 -620 -0.6
rodata 72688 72696 8 0.0
text 451668 454180 2512 0.6
p6 all-clusters-app default (read/write) 2405224 2405224 0 0.0
.bss 117556 117556 0 0.0
.data 2600 2600 0 0.0
.text 1363488 1363488 0 0.0
light-app default (read/write) 2330080 2330080 0 0.0
.bss 106128 106128 0 0.0
.data 2392 2392 0 0.0
.text 1288344 1288344 0 0.0
lock-app default (read/write) 2299104 2299104 0 0.0
.bss 104976 104976 0 0.0
.data 2344 2344 0 0.0
.text 1257368 1257368 0 0.0
qpg lighting-app qpg6105+debug (read only) 565088 565088 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89960 89960 0 0.0
.data 1048 1048 0 0.0
.text 559768 559768 0 0.0
lock-app qpg6105+debug (read only) 515500 515500 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88584 88584 0 0.0
.data 972 972 0 0.0
.text 510180 510180 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 840826 842854 2028 0.2
bss 87316 86904 -412 -0.5
noinit 37160 37160 0 0.0
text 587790 590216 2426 0.4

@lmpprk lmpprk force-pushed the shell-cmd-suggestion branch from dcbe1d4 to b7295ce Compare January 21, 2022 08:31
@lmpprk lmpprk changed the title Add command autocompletion interface, and implement for Zephyr shell nrfconnect, esp32, add CLI tab-to-autocomplete ability Jan 21, 2022
@github-actions
Copy link

github-actions bot commented Jan 21, 2022 •
edited
Loading

PR #13630: Size comparison from b6e08a8 to b7295ce

Increases above 0.2%:

platform target config section b6e08a8 b7295ce change % change
cyw30739 light cyw930739m2evb_01 .app_xip_area 478836 480152 1316 0.3
linux thermostat-no-ble arm64 .got 4064 4080 16 0.4
mbed shell CY8CPROTO_062_4343W+release .data 4864 4888 24 0.5
nrfconnect shell nrf52840dk_nrf52840 (read/write) 798479 800419 1940 0.2
text 533884 536392 2508 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 711294 713234 1940 0.3
text 451564 454072 2508 0.6
telink lighting-app tlsr9518adk80d text 587730 590156 2426 0.4
Increases (6 builds for cyw30739, linux, mbed, nrfconnect, telink)
platform target config section b6e08a8 b7295ce change % change
cyw30739 light cyw930739m2evb_01 (read/write) 573814 574218 404 0.1
.app_xip_area 478836 480152 1316 0.3
linux thermostat-no-ble arm64 (read only) 2048444 2052556 4112 0.2
.got 4064 4080 16 0.4
.text 1703648 1707712 4064 0.2
mbed shell CY8CPROTO_062_4343W+release (read/write) 2054256 2055984 1728 0.1
.data 4864 4888 24 0.5
.text 1016856 1018584 1728 0.2
nrfconnect shell nrf52840dk_nrf52840 (read/write) 798479 800419 1940 0.2
rodata 78324 78328 4 0.0
text 533884 536392 2508 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 711294 713234 1940 0.3
rodata 72624 72628 4 0.0
text 451564 454072 2508 0.6
telink lighting-app tlsr9518adk80d (read/write) 840934 842978 2044 0.2
text 587730 590156 2426 0.4
Decreases (6 builds for cyw30739, linux, mbed, nrfconnect, telink)
platform target config section b6e08a8 b7295ce change % change
cyw30739 light cyw930739m2evb_01 .bss 77716 76804 -912 -1.2
linux thermostat-no-ble arm64 (read/write) 145681 144097 -1584 -1.1
.bss 64785 63185 -1600 -2.5
mbed shell CY8CPROTO_062_4343W+release .bss 156876 156036 -840 -0.5
nrfconnect shell nrf52840dk_nrf52840 bss 109776 109156 -620 -0.6
nrf5340dk_nrf5340_cpuapp bss 107664 107044 -620 -0.6
telink lighting-app tlsr9518adk80d bss 87488 87076 -412 -0.5
Full report (31 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b6e08a8 b7295ce change % change
cyw30739 light cyw930739m2evb_01 (read/write) 573814 574218 404 0.1
.app_xip_area 478836 480152 1316 0.3
.bss 77716 76804 -912 -1.2
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 834948 834948 0 0.0
(read/write) 127244 127244 0 0.0
.bss 125344 125344 0 0.0
.data 1900 1900 0 0.0
.text 834940 834940 0 0.0
BRD4161A+rpc (read only) 822352 822352 0 0.0
(read/write) 143904 143904 0 0.0
.bss 141904 141904 0 0.0
.data 2000 2000 0 0.0
.text 822344 822344 0 0.0
window-app BRD4161A (read only) 805508 805508 0 0.0
(read/write) 125812 125812 0 0.0
.bss 123960 123960 0 0.0
.data 1852 1852 0 0.0
.text 805500 805500 0 0.0
k32w light k32w061+release (read/write) 659928 659928 0 0.0
.bss 76600 76600 0 0.0
.data 1868 1868 0 0.0
.text 575660 575660 0 0.0
lock k32w061+release (read/write) 660732 660732 0 0.0
.bss 76848 76848 0 0.0
.data 1888 1888 0 0.0
.text 576196 576196 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8472012 8472012 0 0.0
(read/write) 390001 390001 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 260368 260368 0 0.0
.dynamic 560 560 0 0.0
.got 68704 68704 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 435188 435188 0 0.0
.text 7200308 7200308 0 0.0
thermostat-no-ble arm64 (read only) 2048444 2052556 4112 0.2
(read/write) 145681 144097 -1584 -1.1
.bss 64785 63185 -1600 -2.5
.data 904 904 0 0.0
.data.rel.ro 72968 72968 0 0.0
.dynamic 560 560 0 0.0
.got 4064 4080 16 0.4
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 130380 130380 0 0.0
.text 1703648 1707712 4064 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351128 2351128 0 0.0
.bss 189444 189444 0 0.0
.data 5304 5304 0 0.0
.text 1313704 1313704 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2333696 2333696 0 0.0
.bss 180960 180960 0 0.0
.data 5584 5584 0 0.0
.text 1296296 1296296 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304048 2304048 0 0.0
.bss 179952 179952 0 0.0
.data 5560 5560 0 0.0
.text 1266648 1266648 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2055984 1728 0.1
.bss 156876 156036 -840 -0.5
.data 4864 4888 24 0.5
.text 1016856 1018584 1728 0.2
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 942287 942287 0 0.0
bss 119040 119040 0 0.0
rodata 108772 108772 0 0.0
text 636896 636896 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 927783 927783 0 0.0
bss 116084 116084 0 0.0
rodata 101220 101220 0 0.0
text 632292 632292 0 0.0
nrf52840dongle_nrf52840 (read/write) 992963 992963 0 0.0
bss 121884 121884 0 0.0
rodata 113524 113524 0 0.0
text 669096 669096 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 852142 852142 0 0.0
bss 115828 115828 0 0.0
rodata 101944 101944 0 0.0
text 553816 553816 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 911663 911663 0 0.0
bss 118196 118196 0 0.0
rodata 103740 103740 0 0.0
text 612336 612336 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 821714 821714 0 0.0
bss 115012 115012 0 0.0
rodata 96964 96964 0 0.0
text 529288 529288 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 914519 914519 0 0.0
bss 117960 117960 0 0.0
rodata 104100 104100 0 0.0
text 614984 614984 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 909703 909703 0 0.0
bss 117984 117984 0 0.0
rodata 103252 103252 0 0.0
text 611008 611008 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798479 800419 1940 0.2
bss 109776 109156 -620 -0.6
rodata 78324 78328 4 0.0
text 533884 536392 2508 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 711294 713234 1940 0.3
bss 107664 107044 -620 -0.6
rodata 72624 72628 4 0.0
text 451564 454072 2508 0.6
p6 all-clusters-app default (read/write) 2409072 2409072 0 0.0
.bss 117788 117788 0 0.0
.data 2584 2584 0 0.0
.text 1367336 1367336 0 0.0
light-app default (read/write) 2330040 2330040 0 0.0
.bss 105536 105536 0 0.0
.data 2408 2408 0 0.0
.text 1288304 1288304 0 0.0
lock-app default (read/write) 2299024 2299024 0 0.0
.bss 104392 104392 0 0.0
.data 2360 2360 0 0.0
.text 1257288 1257288 0 0.0
qpg lighting-app qpg6105+debug (read only) 566840 566840 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89680 89680 0 0.0
.data 1064 1064 0 0.0
.text 561520 561520 0 0.0
lock-app qpg6105+debug (read only) 515336 515336 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88256 88256 0 0.0
.data 988 988 0 0.0
.text 510016 510016 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 840934 842978 2044 0.2
bss 87488 87076 -412 -0.5
noinit 37160 37160 0 0.0
text 587730 590156 2426 0.4

Damian-Nordic
Damian-Nordic reviewed Jan 21, 2022
View reviewed changes
woody-apple
woody-apple approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking, given > 3 days of review & tooling changes.

@lmpprk lmpprk changed the title nrfconnect, esp32, add CLI tab-to-autocomplete ability add CLI tab-to-autocomplete ability and implement for nrfconnect Jan 26, 2022
@github-actions
Copy link

github-actions bot commented Jan 26, 2022 •
edited
Loading

PR #13630: Size comparison from 246473c to e09593f

Increases (2 builds for cyw30739, telink)
platform target config section 246473c e09593f change % change
cyw30739 light cyw930739m2evb_01 .app_xip_area 483384 483524 140 0.0
telink lighting-app tlsr9518adk80d (read/write) 846030 846674 644 0.1
text 591096 592182 1086 0.2
Decreases (3 builds for cyw30739, linux, telink)
platform target config section 246473c e09593f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578462 577578 -884 -0.2
.bss 77824 76800 -1024 -1.3
linux thermostat-no-ble arm64 (read/write) 147457 146561 -896 -0.6
.bss 65857 64961 -896 -1.4
telink lighting-app tlsr9518adk80d bss 87608 87124 -484 -0.6
Full report (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section 246473c e09593f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578462 577578 -884 -0.2
.app_xip_area 483384 483524 140 0.0
.bss 77824 76800 -1024 -1.3
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 840836 840836 0 0.0
(read/write) 127364 127364 0 0.0
.bss 125464 125464 0 0.0
.data 1900 1900 0 0.0
.text 840828 840828 0 0.0
BRD4161A+rpc (read only) 828208 828208 0 0.0
(read/write) 144024 144024 0 0.0
.bss 142024 142024 0 0.0
.data 2000 2000 0 0.0
.text 828200 828200 0 0.0
window-app BRD4161A (read only) 815228 815228 0 0.0
(read/write) 126020 126020 0 0.0
.bss 124164 124164 0 0.0
.data 1856 1856 0 0.0
.text 815220 815220 0 0.0
k32w light k32w061+release (read/write) 664644 664644 0 0.0
.bss 77596 77596 0 0.0
.data 1868 1868 0 0.0
.text 579380 579380 0 0.0
lock k32w061+release (read/write) 665696 665696 0 0.0
.bss 77860 77860 0 0.0
.data 1892 1892 0 0.0
.text 580144 580144 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8728948 8728948 0 0.0
(read/write) 392273 392273 0 0.0
.bss 56241 56241 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 261872 261872 0 0.0
.dynamic 560 560 0 0.0
.got 69280 69280 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 534444 534444 0 0.0
.text 7352756 7352756 0 0.0
thermostat-no-ble arm64 (read only) 2058404 2058404 0 0.0
(read/write) 147457 146561 -896 -0.6
.bss 65857 64961 -896 -1.4
.data 904 904 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 560 560 0 0.0
.got 4112 4112 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 131396 131396 0 0.0
.text 1711248 1711248 0 0.0
p6 all-clusters-app default (read/write) 2414704 2414704 0 0.0
.bss 117892 117892 0 0.0
.data 2584 2584 0 0.0
.text 1372968 1372968 0 0.0
light-app default (read/write) 2336424 2336424 0 0.0
.bss 105644 105644 0 0.0
.data 2408 2408 0 0.0
.text 1294688 1294688 0 0.0
lock-app default (read/write) 2303720 2303720 0 0.0
.bss 105396 105396 0 0.0
.data 2360 2360 0 0.0
.text 1261984 1261984 0 0.0
qpg lighting-app qpg6105+debug (read only) 570044 570044 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89800 89800 0 0.0
.data 1060 1060 0 0.0
.text 564724 564724 0 0.0
lock-app qpg6105+debug (read only) 517724 517724 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89280 89280 0 0.0
.data 992 992 0 0.0
.text 512404 512404 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 846030 846674 644 0.1
bss 87608 87124 -484 -0.6
noinit 37160 37160 0 0.0
text 591096 592182 1086 0.2

@lmpprk lmpprk requested a review from Damian-Nordic January 26, 2022 09:29
@woody-apple
Copy link
Contributor

/rebase

@github-actions
Copy link

github-actions bot commented Jan 27, 2022 •
edited
Loading

PR #13630: Size comparison from 812f820 to 1846966

Increases (4 builds for cyw30739, esp32, nrfconnect, telink)
platform target config section 812f820 1846966 change % change
cyw30739 light cyw930739m2evb_01 .app_xip_area 485336 485476 140 0.0
esp32 all-clusters-app m5stack (read only) 972227 972395 168 0.0
.flash.rodata 210232 210264 32 0.0
.flash.text 966843 967011 168 0.0
nrfconnect shell nrf52840dk_nrf52840 (read/write) 798203 798303 100 0.0
rodata 78288 78324 36 0.0
text 533640 534564 924 0.2
telink lighting-app tlsr9518adk80d (read/write) 848158 848810 652 0.1
text 592932 594022 1090 0.2
Decreases (5 builds for cyw30739, esp32, linux, nrfconnect, telink)
platform target config section 812f820 1846966 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580442 579558 -884 -0.2
.bss 77852 76828 -1024 -1.3
esp32 all-clusters-app m5stack (read/write) 452016 450904 -1112 -0.2
.dram0.bss 75624 74480 -1144 -1.5
linux thermostat-no-ble arm64 (read/write) 151873 150977 -896 -0.6
.bss 69585 68689 -896 -1.3
nrfconnect shell nrf52840dk_nrf52840 bss 109776 108908 -868 -0.8
telink lighting-app tlsr9518adk80d bss 87640 87164 -476 -0.5
Full report (32 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 812f820 1846966 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580442 579558 -884 -0.2
.app_xip_area 485336 485476 140 0.0
.bss 77852 76828 -1024 -1.3
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 843492 843492 0 0.0
(read/write) 127396 127396 0 0.0
.bss 125496 125496 0 0.0
.data 1900 1900 0 0.0
.text 843484 843484 0 0.0
BRD4161A+rpc (read only) 830864 830864 0 0.0
(read/write) 144056 144056 0 0.0
.bss 142056 142056 0 0.0
.data 2000 2000 0 0.0
.text 830856 830856 0 0.0
window-app BRD4161A (read only) 816108 816108 0 0.0
(read/write) 126052 126052 0 0.0
.bss 124196 124196 0 0.0
.data 1856 1856 0 0.0
.text 816100 816100 0 0.0
esp32 all-clusters-app c3devkit (read only) 923298 923298 0 0.0
(read/write) 1384986 1384986 0 0.0
.dram0.bss 70880 70880 0 0.0
.dram0.data 14252 14252 0 0.0
.flash.rodata 180936 180936 0 0.0
.flash.text 923298 923298 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 972227 972395 168 0.0
(read/write) 452016 450904 -1112 -0.2
.dram0.bss 75624 74480 -1144 -1.5
.dram0.data 34032 34032 0 0.0
.flash.rodata 210232 210264 32 0.0
.flash.text 966843 967011 168 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 665224 665224 0 0.0
.bss 77628 77628 0 0.0
.data 1868 1868 0 0.0
.text 579928 579928 0 0.0
lock k32w061+release (read/write) 666192 666192 0 0.0
.bss 77892 77892 0 0.0
.data 1892 1892 0 0.0
.text 580608 580608 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8935692 8935692 0 0.0
(read/write) 394801 394801 0 0.0
.bss 55377 55377 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 264512 264512 0 0.0
.dynamic 560 560 0 0.0
.got 70024 70024 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 544356 544356 0 0.0
.text 7541700 7541700 0 0.0
thermostat-no-ble arm64 (read only) 2082804 2082804 0 0.0
(read/write) 151873 150977 -896 -0.6
.bss 69585 68689 -896 -1.3
.data 960 960 0 0.0
.data.rel.ro 74208 74208 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 131940 131940 0 0.0
.text 1733616 1733616 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357376 2357376 0 0.0
.bss 189588 189588 0 0.0
.data 5296 5296 0 0.0
.text 1319976 1319976 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2341088 2341088 0 0.0
.bss 181104 181104 0 0.0
.data 5584 5584 0 0.0
.text 1303688 1303688 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307832 2307832 0 0.0
.bss 181000 181000 0 0.0
.data 5568 5568 0 0.0
.text 1270432 1270432 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294036 2294036 0 0.0
.bss 177732 177732 0 0.0
.data 5384 5384 0 0.0
.text 1256608 1256608 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983707 983707 0 0.0
bss 120860 120860 0 0.0
rodata 116480 116480 0 0.0
text 668576 668576 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 967571 967571 0 0.0
bss 117904 117904 0 0.0
rodata 108016 108016 0 0.0
text 663248 663248 0 0.0
nrf52840dongle_nrf52840 (read/write) 999827 999827 0 0.0
bss 122032 122032 0 0.0
rodata 115332 115332 0 0.0
text 674004 674004 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 892930 892930 0 0.0
bss 117648 117648 0 0.0
rodata 109780 109780 0 0.0
text 584756 584756 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 916323 916323 0 0.0
bss 119240 119240 0 0.0
rodata 105120 105120 0 0.0
text 614560 614560 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 826358 826358 0 0.0
bss 116056 116056 0 0.0
rodata 98344 98344 0 0.0
text 531512 531512 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 919187 919187 0 0.0
bss 118992 118992 0 0.0
rodata 105632 105632 0 0.0
text 617096 617096 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 914371 914371 0 0.0
bss 119016 119016 0 0.0
rodata 104736 104736 0 0.0
text 613132 613132 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798303 100 0.0
bss 109776 108908 -868 -0.8
rodata 78288 78324 36 0.0
text 533640 534564 924 0.2
p6 all-clusters-app default (read/write) 2418240 2418240 0 0.0
.bss 117932 117932 0 0.0
.data 2592 2592 0 0.0
.text 1376504 1376504 0 0.0
light-app default (read/write) 2339064 2339064 0 0.0
.bss 105684 105684 0 0.0
.data 2408 2408 0 0.0
.text 1297328 1297328 0 0.0
lock-app default (read/write) 2304584 2304584 0 0.0
.bss 105428 105428 0 0.0
.data 2360 2360 0 0.0
.text 1262848 1262848 0 0.0
qpg lighting-app qpg6105+debug (read only) 572036 572036 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89840 89840 0 0.0
.data 1060 1060 0 0.0
.text 566716 566716 0 0.0
lock-app qpg6105+debug (read only) 518164 518164 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89312 89312 0 0.0
.data 992 992 0 0.0
.text 512844 512844 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 848158 848810 652 0.1
bss 87640 87164 -476 -0.5
noinit 37160 37160 0 0.0
text 592932 594022 1090 0.2

@woody-apple woody-apple merged commit c62489b into project-chip:master Jan 27, 2022
woody-apple added a commit that referenced this pull request Jan 27, 2022
@woody-apple
Revert "add CLI tab-to-autocomplete ability and implement for nrfconn…
4c131de 
…ect (#13630)"

This reverts commit c62489b.
@woody-apple woody-apple mentioned this pull request Jan 27, 2022
Merged
woody-apple added a commit that referenced this pull request Jan 27, 2022
@woody-apple
Revert "add CLI tab-to-autocomplete ability and implement for nrfconn…
ba45194 
…ect (#13630)" (#14384)

This reverts commit c62489b.
@lmpprk lmpprk mentioned this pull request Jan 28, 2022
Closed
@lmpprk lmpprk deleted the shell-cmd-suggestion branch January 28, 2022 14:29
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@lmpprk @selissia
add CLI tab-to-autocomplete ability and implement for nrfconnect (pro…
ce3cce9 
…ject-chip#13630)

* implement cli autocompletion for ESP32 and nRFConnect

* avoid STL;revert implementation for esp32

* update to register with nullptr prefix

* cleanup comment

* revert an unnecessary change

* backfill two new commands; address CI failures
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@woody-apple @selissia
Revert "add CLI tab-to-autocomplete ability and implement for nrfconn…
2f59841 
…ect (project-chip#13630)" (project-chip#14384)

This reverts commit c62489b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

Assignees
No one assigned
Labels
examples fast track lib review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tab key doesn't trigger autocomplete for Matter-specific Zephyr CLI commands
3 participants
@lmpprk @woody-apple @Damian-Nordic