Disallow writes to readonly attributes via AttributeAccessInterface #11942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vivien-apple and
wbschiller
bzbarsky-apple
force-pushed
the
disallow-write-to-readonly
branch
from
701de32 to
07aba95
Compare
Refactor WriteSingleClusterData and all dependent functions to take ConcreteAttributePath instead of ClusterInfoconnectedhomeip/src/app/util/ember-compatibility-functions.cpp Lines 569 to 579 in 07aba95 This comment was generated by todo based on a
|
is resolved.connectedhomeip/src/app/util/ember-compatibility-functions.cpp Lines 577 to 587 in 07aba95 This comment was generated by todo based on a
|
Lists not supported in attribute writes yet. }}connectedhomeip/src/controller/java/templates/CHIPClusters-JNI.zapt Lines 205 to 209 in 07aba95 This comment was generated by todo based on a
|
Lists not supported in attribute writes yet. }}connectedhomeip/src/controller/java/templates/ChipClusters-java.zapt Lines 257 to 266 in 07aba95 This comment was generated by todo based on a
|
Lists not supported in attribute writes yet. }}connectedhomeip/src/controller/java/templates/ChipClusters-java.zapt Lines 286 to 293 in 07aba95 This comment was generated by todo based on a
|
yunhanw-google
approved these changes
Nov 17, 2021
|
PR #11942: Size comparison from 494fb9b to 07aba95 Increases (7 builds for k32w, p6, qpg, telink)
Full report (9 builds for k32w, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
disallow-write-to-readonly
branch
from
07aba95 to
b8e8279
Compare
|
PR #11942: Size comparison from 1359f6e to b8e8279 Increases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
@saurabhst @msandstedt @carol-apple @Damian-Nordic @LuDuda @vivien-apple @jepenven-silabs @jmartinez-silabs Please take a look? |
saurabhst
approved these changes
Nov 17, 2021
jepenven-silabs
approved these changes
Nov 18, 2021
…cepted. Need to move the IsReadOnly() check higher up the callstack.
bzbarsky-apple
force-pushed
the
disallow-write-to-readonly
branch
from
b8e8279 to
d7448ac
Compare
|
PR #11942: Size comparison from ef6455d to d7448ac Increases (6 builds for k32w, p6, telink)
Full report (9 builds for k32w, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
disallow-write-to-readonly
branch
from
d7448ac to
e054d94
Compare
|
PR #11942: Size comparison from ef6455d to e054d94 Increases (27 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
This was referenced Nov 18, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
AttributeAccessInterface allows writes to readonly attributes.
Change overview
Disallow those writes by checking for the "writable" flag up front.
Testing
Caught problems in our existing tests that were doing writes to readonly lists. Fixed by making those lists writable. This last bit required a bunch of changes to avoid codegen spitting out broken code to try and write the lists.