Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spring 2024] Handle UpTime attribute becoming mandatory in Rev 2 of General Diagnostics #30023

Closed
tcarmelveilleux opened this issue Oct 26, 2023 · 1 comment · Fixed by #31535
Closed

[Spring 2024] Handle UpTime attribute becoming mandatory in Rev 2 of General Diagnostics #30023

tcarmelveilleux opened this issue Oct 26, 2023 · 1 comment · Fixed by #31535
Assignees
@tcarmelveilleux
Labels
Spec XML align SDK XML does not match the spec (including naming, etc) utility-cluster Work for Utility Clusters
Milestone
1.3 Feature Complete

Comments

@tcarmelveilleux
Copy link
Contributor

  • UpTime attribute became mandatory in Rev 2 of General Diagnostics cluster.
  • Changing Optional to Mandatory has impacts on APIs for some customers
  • Need to determine the right path to express/expose this
@tcarmelveilleux tcarmelveilleux added utility-cluster Work for Utility Clusters Spec XML align SDK XML does not match the spec (including naming, etc) labels Oct 26, 2023
@tcarmelveilleux tcarmelveilleux added this to the 1.3 Feature Complete milestone Oct 26, 2023
@tcarmelveilleux tcarmelveilleux self-assigned this Oct 26, 2023
@tcarmelveilleux
Copy link
Contributor Author

Kept optional (for API backwards compatibility), but made mandatory in Root Node device type in ZAP config, and it is now cert-tested for presence in TC-DGGEN-1.1 and TC-DGGEN-2.1.

tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this issue Jan 19, 2024
@tcarmelveilleux
Make UpTime attribute mandatory in ZAP RootNode
a3f1278 
- ZAP tool RootNode device type now has UpTime mandatory. It is
  only mandatory for rev >= 2 (e.g. current rev) but could not
  be made mandatory in SDK "directly" since it was optional before.
  Now the test cases check for UpTime presence to be mandatory
  (TC-DGGEN-1.1), but this change makes it so ZAP will warn if
  somehow the attribute is not present.

Fixes project-chip#30023

Testing done:
  - Ran ZAP tool and saw the warning on removing UpTime attribute
    in Endpoint 0.
@tcarmelveilleux tcarmelveilleux mentioned this issue Jan 19, 2024
Merged
@mergify mergify bot closed this as completed in #31535 Jan 19, 2024
mergify bot pushed a commit that referenced this issue Jan 19, 2024
@tcarmelveilleux
Make UpTime attribute mandatory in ZAP RootNode (#31535)
b2ff997 
- ZAP tool RootNode device type now has UpTime mandatory. It is
  only mandatory for rev >= 2 (e.g. current rev) but could not
  be made mandatory in SDK "directly" since it was optional before.
  Now the test cases check for UpTime presence to be mandatory
  (TC-DGGEN-1.1), but this change makes it so ZAP will warn if
  somehow the attribute is not present.

Fixes #30023

Testing done:
  - Ran ZAP tool and saw the warning on removing UpTime attribute
    in Endpoint 0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcarmelveilleux tcarmelveilleux

Labels
Spec XML align SDK XML does not match the spec (including naming, etc) utility-cluster Work for Utility Clusters
Projects
[1.3] SDK Feature Complete
Archived in project
[Enhancements] Spec/XML Alignment
Archived in project
Milestone
1.3 Feature Complete
Development

Successfully merging a pull request may close this issue.

Make UpTime attribute mandatory in ZAP RootNode tcarmelveilleux/connectedhomeip
1 participant
@tcarmelveilleux