Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restore ability to control HTTP config and set TCP_NODELAY #99

Merged

Conversation

neoeinstein
Copy link
Contributor

Add a NoDelayAcceptor that can be used to set the TCP_NODELAY flag on accepted streams. Also exposes a Builder from hyper-util to allow for a user to configure the HTTP options they previously did.

Unfortunately, the hyper-util builder is not Clone or Debug, even though the field types are, so I needed to manually derive Debug for Server and used an Arc to reuse the Builder in the various accept tasks. Those workarounds can be removed if hyperium/hyper-util#72 is accepted.

@abs0luty abs0luty merged commit 5690d7e into programatik29:master Dec 8, 2023
@abs0luty
Copy link
Collaborator

abs0luty commented Dec 8, 2023

Thanks ❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants