[BUG] Fix some types of BPMN Json model #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csouchet
force-pushed
the
Fix_types_of_bpmn_json_model
branch
from
a55272b to
c278e73
Compare
tbouffard
approved these changes
Aug 3, 2020
| const json = { | ||
| definitions: { | ||
| targetNamespace: '', | ||
| process: { | ||
| association: [ | ||
| { | ||
| id: 'association_id_0', | ||
| name: 'association name', |
There was a problem hiding this comment.
❓ why removing the name? is something that does not exist in the BPMN spec?
There was a problem hiding this comment.
Yes, in the BPMN specification/XDS, there is no name in the association 😉
| return element as T; | ||
| } | ||
|
|
||
| export function ensureIsArray<T>(elements: (T | string)[] | T | string, acceptEmptyString = false): Array<T> { |
There was a problem hiding this comment.
❓ is the introduction of generics also done to cover #421 (remove usage of any)?
There was a problem hiding this comment.
I didn't see that. I introduce that to be sure what we manipulate after calling this method, in order to use the BPMN Json interfaces :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need in the future to simplify/merge BPMN Json model with our internal model, in order to remove some useless conversion