Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Remove json2typescript dependency #443

Merged
merged 7 commits into from
Aug 4, 2020
Merged

[REFACTOR] Remove json2typescript dependency #443

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b84fdbd
Remove json2typescript dependency, and refactor the code
csouchet Jul 30, 2020
080a1f5
Change return type in some converters
csouchet Jul 30, 2020
a641b0c
Fix some types of BPMN Json model
csouchet Jul 30, 2020
b0baa07
Fix lint-check
csouchet Jul 30, 2020
c552e36
Update doc
csouchet Aug 3, 2020
1d31f6b
Remove unnecessary check
csouchet Aug 3, 2020
6bbe134
Remove unnecessary 'public' declaration
csouchet Aug 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/component/parser/json/converter/DiagramConverter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,7 @@ export default class DiagramConverter extends AbstractConverter<BpmnModel> {
}

private deserializeWaypoints(waypoints: Point[]): Waypoint[] {
if (waypoints) {
return ensureIsArray(waypoints).map(waypoint => new Waypoint(waypoint.x, waypoint.y));
}
return ensureIsArray(waypoints).map(waypoint => new Waypoint(waypoint.x, waypoint.y));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the check removal

}

private deserializeLabel(bpmnLabel: string | BPMNLabel, id: string): Label {
Expand Down