Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint): enable 3 rules of the unicorn plugin #2912

Merged
merged 6 commits into from
Oct 6, 2023

Conversation

@csouchet csouchet added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Oct 5, 2023
@csouchet csouchet changed the title chore(eslint): add unicorn/prefer-at, unicorn/prefer-dom-node-dataset, unicorn/text-encoding-identifier-case rules chore(eslint): add unicorn/prefer-at, unicorn/prefer-dom-node-dataset, unicorn/text-encoding-identifier-case rules Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

🎊 PR Preview 850f25a has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-2912.surge.sh

🕐 Build time: 0.014s

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

♻️ PR Preview 850f25a has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@csouchet csouchet marked this pull request as ready for review October 5, 2023 14:48
@csouchet csouchet requested a review from tbouffard October 5, 2023 14:49
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Please find a shorter name for this PR and its related commit.
Suggestion: "enable 3 rules of the unicorn plugin" and list them in the description

@csouchet csouchet changed the title chore(eslint): add unicorn/prefer-at, unicorn/prefer-dom-node-dataset, unicorn/text-encoding-identifier-case rules chore(eslint): enable 3 rules of the unicorn plugin Oct 6, 2023
@csouchet csouchet merged commit 6cf48c4 into master Oct 6, 2023
@csouchet csouchet deleted the 2742-add_text-encoding-identifier-case_rule branch October 6, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants