Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] consider all Font attributes on rendering #288

Merged
merged 1 commit into from
Jun 4, 2020
Merged

[FEAT] consider all Font attributes on rendering #288

merged 1 commit into from
Jun 4, 2020

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Jun 4, 2020 •
edited
Loading

Done when creating mxGraph elements.

Closes #287

Render with sequence flows test file

Previous implementation
pr_288_01_previous_implementation

With new implementation
pr_288_02_new_implementation

@tbouffard
[FEAT] consider all Font attributes on rendering
9da8272 
Done when creating mxGraph elements.
@tbouffard tbouffard added enhancement New feature or request BPMN rendering Something about the way the lib is rendering BPMN elements labels Jun 4, 2020
@tbouffard tbouffard marked this pull request as ready for review June 4, 2020 15:09
@tbouffard tbouffard merged commit 3afdf5c into master Jun 4, 2020
@tbouffard tbouffard deleted the 287-consider_all_font_attributes_for_rendering branch June 4, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csouchet csouchet csouchet approved these changes

@aibcmars aibcmars Awaiting requested review from aibcmars

@NathalieC NathalieC Awaiting requested review from NathalieC

Assignees
No one assigned
Labels
BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] consider all Font attributes on rendering
2 participants
@tbouffard @csouchet