Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eslint): add eslint-plugin-unicorn dependency and filename-case rule #2833

Merged
merged 5 commits into from
Aug 29, 2023
Merged

chore(eslint): add eslint-plugin-unicorn dependency and filename-case rule #2833

merged 5 commits into from
Aug 29, 2023

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Aug 28, 2023 •
edited
Loading

As there is a lot of changes on the PR #2824, I will activate the rule one-by-one by PR.

For the filename-case rule, I enabled all the cases possible: kebabCase, camelCase, pascalCase and snakeCase.
 

ℹ️ https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/filename-case.md

Covers #2742

@csouchet csouchet added dependencies Pull requests that update a dependency (dev or runtime) chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) refactoring Code refactoring labels Aug 28, 2023
@csouchet csouchet mentioned this pull request Aug 28, 2023
Merged
@csouchet csouchet changed the title chore(eslint): add eslint-plugin-unicorn dependency & filename-case` rule chore(eslint): add eslint-plugin-unicorn dependency and filename-case rule Aug 28, 2023
@github-actions
Copy link

github-actions bot commented Aug 28, 2023 •
edited
Loading

♻️ PR Preview f48c5cd has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Aug 28, 2023 •
edited
Loading

♻️ PR Preview f48c5cd has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@csouchet csouchet mentioned this pull request Aug 25, 2023
Open
23 tasks
@csouchet csouchet marked this pull request as ready for review August 29, 2023 08:27
@csouchet csouchet requested a review from tbouffard August 29, 2023 08:27
@tbouffard tbouffard removed the dependencies Pull requests that update a dependency (dev or runtime) label Aug 29, 2023
tbouffard
tbouffard approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
⚠️ I highly suggest to change the version range declaration of the new dependency.
In the past, we accept auto-bump of minor versions. In such versions, there are new rules. In the past, our local linting commands failed after auto-bump (running npm install bump the deps) because our code was not compliant with the new rules.
This was frustrating and we didn't understand that the problems were due to dependency auto bump.

@tbouffard tbouffard changed the title chore(eslint): add eslint-plugin-unicorn dependency and filename-case rule chore(eslint): add eslint-plugin-unicorn dependency and filename-case rule Aug 29, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@csouchet csouchet merged commit 32ff2c7 into master Aug 29, 2023
@csouchet csouchet deleted the 2742-use_unicorn/filename-case_rule branch August 29, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) refactoring Code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csouchet @tbouffard