refactor: split internal registries #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouffard
added
WIP 🚧
|
♻️ PR Preview 1f82ffa has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview 1f82ffa has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
tbouffard
force-pushed
the
refactor/reorg_registries_code
branch
from
868a840 to
2adb3f4
Compare
tbouffard
force-pushed
the
refactor/reorg_registries_code
branch
from
2adb3f4 to
cfb7aa0
Compare
tbouffard
removed
the
WIP 🚧
csouchet
approved these changes
Aug 28, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
BpmnElementsRegistry, extract the remaining code that is not related to the management of BPMN elements.The code related to overlays has already been extracted and the new changes proceed in the same way for CSS classes and style update.
BpmnElementsRegistrymoved to other "registry" files. It is generally glue code :CssClassesRegistryandStyleRegistryGraphCellUpdater, which generally does the real processing, is split into different updaters:CssClassesUpdaterandStyleUpdaterStyleManagerno longer depends onCssClassesCacheto reset styles. This make the "Style" and "CSS" API completely independent and will allow to fully split the registries in the future.In addition, apply refactoring to
OverlaysRegistryfor consistency with other registries.covers #2803
relates to #2800
Additional checks done to verify the implementation
Notes
Additional refactoring will follow to complete #2803 (interfaces extraction).