Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate the documentation generation script to ESM #2792

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

tbouffard
Copy link
Member

Ensure that all scripts are consistent and use ESM syntax.

Also switch from the asciidoctor to the @asciidoctor/core npm package as we only call Asciidoctor.js programmatically. We don't need the CLI part provided by the asciidoctor package.

Ensure that all scripts are consistent and use ESM syntax.

Also switch from the `asciidoctor` to the `@asciidoctor/core` npm package as we only call AsciiDoctor programmatically.
We don't need the CLI part provided by the `asciidoctor` package.
@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Aug 17, 2023
@tbouffard tbouffard requested a review from csouchet August 17, 2023 12:18
@github-actions
Copy link

github-actions bot commented Aug 17, 2023

♻️ PR Preview b1eba83 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Aug 17, 2023

♻️ PR Preview b1eba83 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@csouchet
Copy link
Member

Enregistrement.de.l.ecran.2023-08-17.a.14.22.30.mov

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tbouffard tbouffard merged commit 7f09c8d into master Aug 17, 2023
@tbouffard tbouffard deleted the refactor/use_esm_in_docs_generation_script branch August 17, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants