[DOC] architecture additions #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouffard
added
documentation
tbouffard
force-pushed
the
doc_architecture_additions
branch
from
3c370df to
2b20232
Compare
tbouffard
force-pushed
the
doc_architecture_additions
branch
from
0331c6d to
8da305c
Compare
|
The architecture overview schema should probably be improved, screenshot of commit 40a1cde
|
tbouffard
removed
the
WIP 🚧
csouchet
reviewed
May 27, 2020
csouchet
reviewed
May 27, 2020
csouchet
reviewed
May 27, 2020
|
|
||
| The bpmn input source coordinates are absolute whereas mxgraph uses coordinates in the referential of the parent cell. | ||
| As we define a parent-child relationship when inserting BPMN elements in the mxGraph model, a coordinate transformation | ||
| layer is required. See `MxGraphRenderer` for more details. |
There was a problem hiding this comment.
Suggested change
| layer is required. See `MxGraphRenderer` for more details. | |
| layer is required. See https://github.com/process-analytics/bpmn-visualization-js/blob/d812e36bca8dea8f9275161f2eb9a9a5173a9ca5/src/component/mxgraph/MxGraphRenderer.ts[MxGraphRenderer] for more details. |
There was a problem hiding this comment.
We previously decided to not link the doc to the source code. So I did the same as in the 'bpmn support how to' section: just refer to the class/file name
csouchet
reviewed
May 27, 2020
| All BPMNShape elements are owned directly by a BPMNPlane (that is the root element in a BPMNDiagram), i.e., shapes | ||
| are not nested within each other in the BPMN DI model although they may appear that way when depicted. The bounds | ||
| of a BPMNShape are always relative to that plane’s origin point and are REQUIRED to be positive coordinates. Note that | ||
| the bounds’ x and y coordinates are the position of the upper left corner of the shape (relative to the upper left corner of |
There was a problem hiding this comment.
Suggested change
| the bounds’ x and y coordinates are the position of the upper left corner of the shape (relative to the upper left corner of | |
| the x and y coordinates of the bounds are the position of the upper left corner of the shape (relative to the upper left corner of |
There was a problem hiding this comment.
I would left it as it, it is the strict copy of the BPMN specification content
Co-authored-by: Souchet Céline <4921914+csouchet@users.noreply.github.com>
csouchet
reviewed
May 27, 2020
Comment on lines
+88
to
+89
| The bounds of BPMNLabel are always relative to the containing plane’s origin point. Note that the bounds’ x and y | ||
| coordinates are the position of the upper left corner of the label (relative to the upper left corner of the plane). |
There was a problem hiding this comment.
Suggested change
| The bounds of BPMNLabel are always relative to the containing plane’s origin point. Note that the bounds’ x and y | |
| coordinates are the position of the upper left corner of the label (relative to the upper left corner of the plane). | |
| The bounds of BPMNLabel are always relative to the containing plane’s origin point. Note that the x and y coordinates | |
| of the bounds are the position of the upper left corner of the label (relative to the upper left corner of the plane). |
There was a problem hiding this comment.
it is the strict copy of the BPMN specification content (same remark as above)
csouchet
reviewed
May 27, 2020
docs/bpmn-support.adoc
Outdated
|
|
||
| |Call Activity | ||
| | | ||
| | | ||
| |=== |
csouchet
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #109
Closes #174