Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] display call activity #258

Merged
merged 8 commits into from
May 22, 2020
Merged

[FEAT] display call activity #258

merged 8 commits into from
May 22, 2020

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented May 17, 2020 •
edited
Loading

Closes #77

Render of the B.1.0.bpmn file from BPMN-MIWG

image

@tbouffard tbouffard added enhancement New feature or request BPMN support Something about the BPMN specification that the lib is already supporting or will support labels May 17, 2020
csouchet
csouchet reviewed May 19, 2020
View reviewed changes
Copy link
Member

@csouchet csouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Missing update of docs/bpmn-support.adoc to inform the user/dev that we support Call Activity 😉

@csouchet
Copy link
Member

⚠️ Don't forget to uncomment the test for Call Activity in the test class for Conditional Sequence Flow, if we merge this PR after.

@CLAassistant
Copy link

CLAassistant commented May 19, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tbouffard tbouffard marked this pull request as draft May 19, 2020 14:51
@tbouffard
Copy link
Member Author

tbouffard commented May 19, 2020 •
edited
Loading

We are going to merge #257 first, then integrate the conditional sequence flow support for call activity here prior being able to merge.

@csouchet csouchet added the rebase needed 💥 Pull request that must be rebased on the latest master commit prior being reviewed or merged label May 19, 2020
@tbouffard tbouffard force-pushed the 77-Display_call_activity branch from 8be32ef to 092e92e Compare May 20, 2020 13:31
@tbouffard tbouffard removed the rebase needed 💥 Pull request that must be rebased on the latest master commit prior being reviewed or merged label May 20, 2020
@tbouffard tbouffard marked this pull request as ready for review May 20, 2020 14:23
@tbouffard
Copy link
Member Author

Rebased on master. Conditional sequence flow support added.

@tbouffard tbouffard requested review from csouchet and aibcmars May 20, 2020 14:24
@tbouffard tbouffard merged commit 9cb85de into master May 22, 2020
@tbouffard tbouffard deleted the 77-Display_call_activity branch May 22, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csouchet csouchet csouchet approved these changes

@aibcmars aibcmars Awaiting requested review from aibcmars

Assignees
No one assigned
Labels
BPMN support Something about the BPMN specification that the lib is already supporting or will support enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Display Call activity
3 participants
@tbouffard @csouchet @CLAassistant