Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] Add option to add Participant on JsonBuilder #2100

Merged
merged 1 commit into from
Jul 8, 2022
Merged

[TEST] Add option to add Participant on JsonBuilder #2100

merged 1 commit into from
Jul 8, 2022

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Jul 8, 2022 •
edited
Loading

Modify JsonBuilder:

  • Introduce BuildDefinitionParameter & BuildExclusiveGatewayParameter interface
  • Add option to add Participant in the generated json
  • Add unit tests

It's the second step to simplify the unit tests of the JsonParser. To see the final result, see #2098.

@csouchet csouchet added chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first labels Jul 8, 2022
@csouchet csouchet force-pushed the Add_Participant_from_JsonBuilder_test_utils branch from c5d3d93 to 528987e Compare July 8, 2022 08:32
@csouchet csouchet mentioned this pull request Jul 8, 2022
Merged
@csouchet
Modify JsonBuilder:
9a9515d 
- Introduce BuildDefinitionParameter & BuildExclusiveGatewayParameter interface
- Add option to add Participant in the generated json
- Add unit tests
@csouchet csouchet force-pushed the Add_Participant_from_JsonBuilder_test_utils branch from 528987e to 9a9515d Compare July 8, 2022 11:12
@csouchet csouchet removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Jul 8, 2022
@csouchet csouchet marked this pull request as ready for review July 8, 2022 11:16
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@csouchet csouchet requested review from oanesini and tbouffard July 8, 2022 11:43
@csouchet csouchet enabled auto-merge (squash) July 8, 2022 12:23
@csouchet csouchet disabled auto-merge July 8, 2022 12:26
@csouchet csouchet merged commit f9220f6 into master Jul 8, 2022
@csouchet csouchet deleted the Add_Participant_from_JsonBuilder_test_utils branch July 8, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oanesini oanesini Awaiting requested review from oanesini

@tbouffard tbouffard Awaiting requested review from tbouffard

Assignees
No one assigned
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@csouchet