Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Improve surge preview workflows #2072

Merged
merged 8 commits into from
Jun 27, 2022

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Jun 24, 2022

Remove duplication by introducing a custom action. We now run a single job instead of 2 jobs with cryptic secret checks.
Delegate most of the work to the https://github.com/bonitasoft/actions surge-preview-tools action to better manage PR created from fork repositories or by Dependabot.
We shouldn't have error on PR close when it was created by dependabot: most of the time the preview doesn't exist. We previously had errors because we always tried to teardown the surge domain even when it didn't exist. This is now fixed.

Previously valided with process-analytics/github-actions-playground#103

@tbouffard tbouffard added chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft labels Jun 24, 2022
@github-actions
Copy link

github-actions bot commented Jun 24, 2022

♻️ PR Preview f8d8ae8 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Jun 24, 2022

♻️ PR Preview f8d8ae8 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@tbouffard tbouffard changed the title [INFRA] Improve surge preview workflow [INFRA] Improve surge preview workflows Jun 24, 2022
@tbouffard tbouffard requested a review from csouchet June 24, 2022 17:23
@tbouffard tbouffard removed the WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft label Jun 24, 2022
@tbouffard tbouffard marked this pull request as ready for review June 24, 2022 17:23
@tbouffard tbouffard merged commit 520653b into master Jun 27, 2022
@tbouffard tbouffard deleted the infra/prevent_preview_error_with_dependabot branch June 27, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants