[TEST] Improve integration tests about the lib initialization #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add integration tests to test all combinations of initialization options. It lets detect that the implementation can be simplified. Hide console warnings generated by the parsing code in integration tests. This makes the output clearer and help to highlight real problems. Remove jest spies on `console` in parsing unit tests. There is no such calls as we use a custom parsing warning collector in tests.
tbouffard
added
the
chore
|
♻️ PR Preview ef12b44 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview ef12b44 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
Kudos, SonarCloud Quality Gate passed! |
csouchet
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add integration tests to test all combinations of initialization options.
It lets detect that the implementation can be simplified.
Hide console warnings generated by the parsing code in integration tests. This makes the output clearer and help
to highlight real problems.
Remove jest spies on
consolein parsing unit tests. There is no such calls as we use a custom parsing warningcollector in tests.