Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Simplify imports of expected model elements #2067

Merged
merged 2 commits into from
Jun 24, 2022

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Jun 23, 2022

JsonTestUtils re-exported all exports of helpers/bpmn-model-expect.
This was a temporary solution after the verifyShape and verifyEdge functions were moved to the bpmn-model-expect file.
The re-export is now removed.

@tbouffard tbouffard added depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first refactoring Code refactoring labels Jun 23, 2022
@github-actions
Copy link

github-actions bot commented Jun 23, 2022

🎊 PR Preview 1e1024a has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-2067.surge.sh

🕐 Build time: 15.621s

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Jun 23, 2022

🎊 PR Preview 1e1024a has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-2067.surge.sh

🕐 Build time: 12.761s

🤖 By surge-preview

`JsonTestUtils` re-exported all exports of `helpers/bpmn-model-expect`.
This was a temporary solution after the `verifyShape` and `verifyEdge` functions were moved to the `bpmn-model-expect`
file.
The re-export is now removed.
@tbouffard tbouffard force-pushed the test/update_json_parser_tests_imports branch from 1e1024a to bc1915c Compare June 24, 2022 09:21
@tbouffard tbouffard removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Jun 24, 2022
@tbouffard tbouffard marked this pull request as ready for review June 24, 2022 09:22
@tbouffard tbouffard requested a review from csouchet June 24, 2022 09:22
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tbouffard tbouffard merged commit e83f9b8 into master Jun 24, 2022
@tbouffard tbouffard deleted the test/update_json_parser_tests_imports branch June 24, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants