[EXAMPLE] Update assets loading in the demo #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
White logo: use svg source instead of png Remove the 'logo' class assignment as there is no CSS class named 'logo' Use newer fontawesome v6 icons
tbouffard
added
the
example
|
♻️ PR Preview 7cf18a1 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
tbouffard
commented
May 6, 2022
| @@ -4,7 +4,7 @@ | |||
| <meta charset="UTF-8"> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no"> | |||
| <title>BPMN Visualization Demo</title> | |||
| <link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.3.1/css/all.css"> | |||
| <link rel="stylesheet" href="https://use.fontawesome.com/releases/v6.1.1/css/all.css"> | |||
There was a problem hiding this comment.
Here we are still loading the whole fontawesome resources whereas we are only using 2 classes (the 2 icons of the upload BPMN diagram button).
We may use https://fontawesome.com/v6/docs/web/setup/use-kit to create a minimal file that fit our needs.
csouchet
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
White logo: use svg source instead of png
Remove the 'logo' class assignment as there is no CSS class named 'logo'
Use newer fontawesome v6 icons