Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Fix .eslintignore to consider files in config folders #1353

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

tbouffard
Copy link
Member

Update the configuration to only ignore folders at project root. To prevent new
errors in the future, also do this for the build and dist folders.
Fix lint errors in files in the config folders.

Update the configuration to only ignore folders at project root. To prevent new
errors in the future, also do this for the `build` and `dist` folders.
Fix lint errors in files in the `config` folders.
@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Jun 9, 2021
@tbouffard tbouffard requested review from csouchet and aibcmars June 9, 2021 14:34
@github-actions
Copy link

github-actions bot commented Jun 9, 2021

♻️ PR Preview 26caa4e has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Jun 9, 2021

♻️ PR Preview 26caa4e has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

Copy link
Member

@csouchet csouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍🏼

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@csouchet csouchet merged commit 024fee0 into master Jun 9, 2021
@csouchet csouchet deleted the infra/update_eslintignore_to_consider_all_sources branch June 9, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants