Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Do not use the 'interaction' term when possible #1328

Merged

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented May 25, 2021

Introduce Overlays and Custom Behavior TSDoc category
API doc: reorganize category and rename API title to match the lib name

closes #926

tbouffard added 2 commits May 25, 2021 10:26
Introduce Overlays TSDoc category
API doc: reorganize category and rename API title to match the lib name
@tbouffard tbouffard added the documentation Improvements or additions to documentation label May 25, 2021
@github-actions
Copy link

github-actions bot commented May 25, 2021

♻️ PR Preview 728b2cb has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented May 25, 2021

♻️ PR Preview 728b2cb has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@@ -29,7 +29,7 @@ export function newBpmnElementsRegistry(bpmnModelRegistry: BpmnModelRegistry, gr
}

/**
* @category Interaction
* @category Custom Behavior
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this is the best name, but at least it is align we the concepts we have documented.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is totally OK

Copy link
Contributor

@aibcmars aibcmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
checked the API documentation - it displays new categories

@aibcmars aibcmars merged commit 90f25b9 into master May 25, 2021
@aibcmars aibcmars deleted the 926-remove_usage_of_the_interaction_term_where_possible branch May 25, 2021 15:18
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Remove remaining usage of 'interaction' in doc and code
2 participants