Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Move static resources out of the main source folder #1318

Merged
merged 3 commits into from
May 27, 2021

Conversation

tbouffard
Copy link
Member

Move assets to a dedicated dev to clearly show that these resources are not
part of the produced library: they are only used for development (and demo).

Move and rename helper static js scripts to a dedicated sub folder
Rename the css file only used in some test pages for clarity
Update documentation about css generation for the demo

@tbouffard tbouffard added the refactoring Code refactoring label May 24, 2021
@github-actions
Copy link

github-actions bot commented May 24, 2021

♻️ PR Preview 3689c41 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented May 24, 2021

♻️ PR Preview 3689c41 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@aibcmars aibcmars added the rebase needed 💥 Pull request that must be rebased on the latest master commit prior being reviewed or merged label May 25, 2021
tbouffard added 2 commits May 25, 2021 17:26
Move assets to a dedicated `dev` to clearly show that these resources are not
part of the produced library: they are only used for development (and demo).

Move and rename helper static js scripts to a dedicated sub folder
Rename the css file only used in some test pages for clarity
Update documentation about css generation for the demo

# Conflicts:
#	package.json
@tbouffard tbouffard force-pushed the refactor/move_test_and_demo_assets_out_of_sources branch from c6f3706 to 44823fb Compare May 25, 2021 15:26
@tbouffard tbouffard removed the rebase needed 💥 Pull request that must be rebased on the latest master commit prior being reviewed or merged label May 25, 2021
Copy link
Contributor

@aibcmars aibcmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally
👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aibcmars aibcmars merged commit 9de6adf into master May 27, 2021
@aibcmars aibcmars deleted the refactor/move_test_and_demo_assets_out_of_sources branch May 27, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants