Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Create a glossary to explain all the concepts #1275

Merged
merged 12 commits into from
May 11, 2021

Conversation

csouchet
Copy link
Member

Closes #1272

@csouchet csouchet added the documentation Improvements or additions to documentation label Apr 30, 2021
@github-actions
Copy link

github-actions bot commented Apr 30, 2021

♻️ PR Preview 4c4721b has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@csouchet csouchet force-pushed the 1272-create_glossary branch 3 times, most recently from ea4a5bc to 642441a Compare April 30, 2021 15:21
@csouchet csouchet force-pushed the 1272-create_glossary branch from 642441a to 074be92 Compare April 30, 2021 15:22
csouchet and others added 2 commits May 5, 2021 17:41
Co-authored-by: Marcin Michniewicz <45601541+aibcmars@users.noreply.github.com>
csouchet and others added 2 commits May 7, 2021 11:17
Co-authored-by: Marcin Michniewicz <45601541+aibcmars@users.noreply.github.com>
@csouchet csouchet marked this pull request as ready for review May 7, 2021 09:18
@@ -30,3 +30,5 @@ include::bpmn-support.adoc[]

include::architecture/00-index.adoc[]

include::glossary.adoc[]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put this before the bpmn-support.
The bpmn-support paragraph is the 1st one that provides details about the lib. Glossary is general paragraph that reminds all import concepts that we use in the lib.

Copy link
Member

@tbouffard tbouffard May 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, we may also add links to the glossary in the rest of the user documentation

@tbouffard tbouffard self-assigned this May 11, 2021
tbouffard added 3 commits May 11, 2021 17:01
Put it right after usage, prior introducing more details about the features
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with my changes 😜

@csouchet csouchet merged commit df159c4 into master May 11, 2021
@csouchet csouchet deleted the 1272-create_glossary branch May 11, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Create a glossary to explain all the concepts
3 participants