Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INFRA] Run WebKit e2e tests on macOS #1197

Merged
merged 11 commits into from
Apr 16, 2021
Merged

[INFRA] Run WebKit e2e tests on macOS #1197

merged 11 commits into from
Apr 16, 2021

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Mar 26, 2021 •
edited
Loading

Skip panning tests on WebKit as they are not working for now.
They will be fixed later.

closes #876

@tbouffard tbouffard added chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft labels Mar 26, 2021
@tbouffard tbouffard changed the title [INFRA] Run e2e tests on webkit and macOS [INFRA] Run WebKit e2e tests on macOS Mar 30, 2021
@tbouffard tbouffard force-pushed the 876-run-tests-on-webkit branch 2 times, most recently from a610993 to ccced5e Compare April 7, 2021 16:03
@tbouffard
Copy link
Member Author

tbouffard commented Apr 8, 2021 •
edited
Loading

In 72d0447, the GH WF run is ok except for the 2 panning tests. Tests act as if there isn't any panning.

In the following diff images generated by the tests, the expect is on top. We also see a strange blue gray background on overlays after panning

diagram navigation - mouse panning Overlay navigation - panning
Error: Expected image to match or be a close match to snapshot but was 17.0066566761894% different from snapshot (81631.95204570913 differing pixels). Error: Expected image to match or be a close match to snapshot but was 17.28512572201066% different from snapshot (82968.60346565118 differing pixels).
mouse panning-diff panning-diff

@csouchet csouchet force-pushed the 876-run-tests-on-webkit branch from 72d0447 to 389a1c0 Compare April 15, 2021 13:28
@tbouffard
Copy link
Member Author

About the panning tests failure - #1197 (comment)
I have also reproduced the failure on my local Ubuntu 18.04 PC running the webkit browser used by playwright.

With @csouchet, we have decided to skip the 2 panning tests for now to make the webkit macos tests run as part of the regular checks. This will let us adding and updating webkit tests at the time we develop features.
At the same time, we will create a new PR right after this one is merged into master to restore the 2 panning tests and investigate how to make them pass.

@tbouffard tbouffard marked this pull request as ready for review April 16, 2021 08:10
@tbouffard tbouffard removed the WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft label Apr 16, 2021
@tbouffard tbouffard requested a review from csouchet April 16, 2021 08:10
This was referenced Apr 16, 2021
Closed
Merged
@csouchet
Copy link
Member

The panniing & zoom tests are failed loccaly on MacOs on Webkit. I agree to skip them, and fix them in another PR.

image

image

@csouchet csouchet added the rebase needed 💥 Pull request that must be rebased on the latest master commit prior being reviewed or merged label Apr 16, 2021
@tbouffard
Copy link
Member Author

tbouffard commented Apr 16, 2021 •
edited
Loading

The panniing & zoom tests are failed loccaly on MacOs on Webkit. I agree to skip them, and fix them in another PR.

@csouchet I guess you only refer to 'panning tests' (for both diagram and overlays) as we only run zoom tests on Chromium (because Playwright currently lacks of some mouse wheel general API to be used on firefox and webkit).

Anyway, thanks for your feedback, we will then investigate the panning issue in #1237.

@tbouffard tbouffard force-pushed the 876-run-tests-on-webkit branch from eee36d2 to dbfdf9d Compare April 16, 2021 09:45
@tbouffard tbouffard removed the rebase needed 💥 Pull request that must be rebased on the latest master commit prior being reviewed or merged label Apr 16, 2021
@tbouffard tbouffard enabled auto-merge (squash) April 16, 2021 09:54
@tbouffard
Revert "fake commit"
13e5acd 
This reverts commit 1a3f0f9
@tbouffard tbouffard merged commit 430beb2 into master Apr 16, 2021
@tbouffard tbouffard deleted the 876-run-tests-on-webkit branch April 16, 2021 11:16
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csouchet csouchet csouchet approved these changes

Assignees
No one assigned
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[INFRA] check the testing possibilities for the Safari browser
2 participants
@tbouffard @csouchet