Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Update types in mxCellRenderer overlays management #1195

Merged
merged 2 commits into from
Mar 25, 2021

Conversation

tbouffard
Copy link
Member

You explicit types instead of any when possible.

You explicit types instead of any when possible.
@tbouffard tbouffard added the refactoring Code refactoring label Mar 24, 2021
@github-actions
Copy link

github-actions bot commented Mar 24, 2021

♻️ PR Preview e4173a6 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Mar 24, 2021

♻️ PR Preview e4173a6 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@tbouffard tbouffard changed the title [REFACTOR] update types in mxCellRenderer overlays management [REFACTOR] Update types in mxCellRenderer overlays management Mar 25, 2021
Copy link
Contributor

@aibcmars aibcmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csouchet csouchet self-requested a review March 25, 2021 10:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@csouchet csouchet merged commit 3e91a16 into master Mar 25, 2021
@csouchet csouchet deleted the refactor/improve_type_in_ShapeConfigurator branch March 25, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants