Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Rename the 'add overlays' API #1190

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Mar 22, 2021

In addition, fix the TSDoc examples that were incorrect.

@csouchet csouchet added the documentation Improvements or additions to documentation label Mar 22, 2021
@csouchet csouchet requested review from aibcmars and tbouffard March 22, 2021 13:14
@github-actions
Copy link

github-actions bot commented Mar 22, 2021

♻️ PR Preview f0d8f53 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Mar 22, 2021

♻️ PR Preview f0d8f53 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@tbouffard tbouffard changed the title [DOC] Fix TSDoc for the new API: add overlays [DOC] Rename the 'add overlays' API Mar 22, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@csouchet csouchet merged commit 558cfd3 into master Mar 22, 2021
@csouchet csouchet deleted the fix_tsdoc_for_add_overlay branch March 22, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants