[TEST] Add automatic bundle tests #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouffard
added
chore
tbouffard
force-pushed
the
600-add_automatic_tests_for_iife_bundle
branch
from
002222b to
0343687
Compare
tbouffard
removed
the
depends on another PR ⚠️
Ensure that a page using the bundle is able to display a BPMN diagram. The utils code checking the generated SVG is shared with end-to-end tests. The test is very fast: it doesn't need a dev server to run, the slower part is the puppeteer startup.
Avoid too much workflow This reverts commit 8b94542
tbouffard
force-pushed
the
600-add_automatic_tests_for_iife_bundle
branch
from
0343687 to
75746a3
Compare
tbouffard
requested review from
a team,
csouchet and
aibcmars
and removed request for
a team
tbouffard
changed the title
aibcmars
reviewed
Jan 12, 2021
| @@ -115,7 +115,7 @@ if (!buildBundles) { | |||
| { file: pkg.main, format: 'cjs' }, | |||
| ], | |||
| }; | |||
| rollupConfigs = [configIIFE, configIIFEMinified]; | |||
| rollupConfigs = [configIIFE, configIIFEMinified, configBundles, configBundlesMinified]; | |||
There was a problem hiding this comment.
I guess I removed the other bundles to speedup the generation while testing the new minified IIFE bundle, and we didn't notice the removal 😈
tbouffard
commented
Jan 12, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have a way to check that bundles are generated and the GitHub workflow
checks this each time the build is run.
This test shows that, in 64aa112, we have removed by mistake the CommonJS and ESM
bundles generation.
For the IIFE bundle, we also ensure that a test page using the bundle is able to display
a BPMN diagram. The utils code checking the generated SVG is shared with end-to-end tests.
The test is very fast: it doesn't need a dev server to run, the slower part is
the puppeteer startup.
Adding test has also shown that this page hasn't been migrated correctly when the GlobalOptions
have been refactored in 6335a53.
closes #600