This repository has been archived by the owner on Sep 14, 2019. It is now read-only.
Add TypeScript typings #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimonVS
commented
Jun 24, 2019
| export default function getConfig<T>( | ||
| context: Context, | ||
| fileName: string, | ||
| defaultConfig?: T, |
There was a problem hiding this comment.
I'm unsure if this should be T or Partial<T>
|
Thanks @TimonVS, that looks like a great start! We don’t use yarn in the other probot project. Can you please remove it from your pull request? We could add it to We don’t mind adding |
|
Of course, I must be tired because I assumed the yarn.lock was already there 😅. |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to update
npm-run-allbecause I couldn't install because the specific version offlatmap-streamit used has been unpublished due to malware: mysticatea/npm-run-all#155.In any case, this PR adds typings to the package, I also had to install Probot as a dev dependency to be able to include it in the typings. I'm not sure if that's the correct way but I'd be glad to receive feedback :)
Fixes: #19