Override linop instead of _evaluate_linop
#818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timweiland
requested review from
marvinpfoertner and
JonathanWenger
as code owners
JonathanWenger
approved these changes
May 6, 2023
There was a problem hiding this comment.
LGTM, but maybe @marvinpfoertner should take a quick look as well. I think he may have written this oroginally.
In arithmetic fallback covariance functions, override `linop` instead of `_evaluate_linop`, because the latter has the problem that the input preprocessing destroys attributes of np.array subclasses. Keeping the option of np.array subclassing can be very useful for certain linop implementations, e.g. tensor product covariance functions.
timweiland
force-pushed
the
linop_array_subclass_compatibility
branch
from
1a00636 to
ba3e3d1
Compare
Codecov Report
@@ Coverage Diff @@
## main #818 +/- ##
=======================================
Coverage 91.15% 91.15%
=======================================
Files 218 218
Lines 8216 8216
Branches 1061 1061
=======================================
Hits 7489 7489
Misses 499 499
Partials 228 228
|
marvinpfoertner
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a Nutshell
Override
linopinstead of_evaluate_linopin arithmetic fallback covariance functionsDetailed Description
In arithmetic fallback covariance functions, override
linopinstead of_evaluate_linop, because the latter has the problem that the input preprocessing destroys attributes of np.array subclasses. Keeping the option of np.array subclassing can be very useful for certain linop implementations, e.g. tensor product covariance functions, where you might want to subclass np.array to represent grid structure in the inputs.