Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify function is dead code #40

Closed
0xDatapunk opened this issue Oct 7, 2024 · 2 comments · Fixed by #47
Closed

verify function is dead code #40

0xDatapunk opened this issue Oct 7, 2024 · 2 comments · Fixed by #47
Assignees
Labels
audit 🔍 This issue is related to an audit. good first issue Good for newcomers refactoring ♻️ A code change that neither fixes a bug nor adds a feature

Comments

@0xDatapunk
Copy link

function verify(
BinaryIMTData storage self,
uint256 leaf,
uint256[] calldata proofSiblings,
uint8[] calldata proofPathIndices
) private view returns (bool) {
return InternalBinaryIMT._verify(self, leaf, proofSiblings, proofPathIndices);
}

this is a private function, and is not used anywhere in the file, so it is dead code

@cedoor cedoor added audit 🔍 This issue is related to an audit. refactoring ♻️ A code change that neither fixes a bug nor adds a feature labels Oct 14, 2024
@cedoor cedoor added this to ZK-Kit Oct 14, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in ZK-Kit Oct 14, 2024
@cedoor cedoor added the good first issue Good for newcomers label Oct 24, 2024
@vijaykarthiktk
Copy link
Contributor

comment it or remove it?

@cedoor
Copy link
Member

cedoor commented Nov 22, 2024

Hi @vijaykarthiktk, we can remove it

vijaykarthiktk added a commit to vijaykarthiktk/zk-kit.solidity that referenced this issue Dec 10, 2024
@cedoor cedoor moved this from ♻️ Grooming to 👀 In Review in ZK-Kit Dec 10, 2024
@cedoor cedoor closed this as completed in d047c07 Dec 10, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✔️ Done in ZK-Kit Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit 🔍 This issue is related to an audit. good first issue Good for newcomers refactoring ♻️ A code change that neither fixes a bug nor adds a feature
Projects
Status: ✔️ Done
Development

Successfully merging a pull request may close this issue.

3 participants