Refactoring ecdh to work properly as a lib, extending it to use with other curves #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Merged
cedoor
approved these changes
Feb 20, 2025
TomAFrench
reviewed
Feb 20, 2025
|
|
||
| [dependencies] | ||
| bignum = { git = "https://github.com/noir-lang/noir-bignum", tag = "zpedro/default_trait" } | ||
| bignum = { git = "https://github.com/noir-lang/noir-bignum", tag = "main" } |
There was a problem hiding this comment.
fyi, this will break pretty much immediately. Pulling whatever is latest on master seems like a really bad idea.
There was a problem hiding this comment.
Yeah should've picked a version. Let's see what happens
qpzm
pushed a commit
to ModoriLabs/zk-kit.noir
that referenced
this pull request
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #25
closes #21