Port accumulated typos-PRs branch to main #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a typo in the text
* Update nimfs.rs * Update utils.rs ---------
Corrected preposition in the solidity-verifiers description
* Update README.md * Update README.md * Update README.md
* typo kzg.rs * typo virtual_polynomial.rs * typo gadgets.rs * typo nova.rs
* Update main.rs * Fix rustfmt errors --------- Co-authored-by: Игорь <igor@MacBook-Pro.local>
* Fix spelling kzg.rs * Fix spelling virtual_polynomial.rs * Fix spelling gadgets.rs
winderica
approved these changes
Feb 22, 2025
There was a problem hiding this comment.
LGTM, thank you for maintaining this branch and keeping it updated!
It is great that we already have a spell checker in our CI, and I plan to add a grammar checker (e.g., https://github.com/Automattic/harper) as well, so we hopefully no longer need to manually review these typo/grammar related PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over these past 3 months, there has been a bit of an increase of PRs "fixing typos" (mostly 'airdrop-farming' aspirations). I've been tagging them with the label
typos, merging them in a separate branch (typos-aggr) and keeping that branch up-to-date (rebasing tomainat newmaincommits to keep thetypos-aggrbranch up-to-date to avoid potential git-conflicts), with the idea of every some months merging it all-together in a single PR to themainbranch.We have now 10 different PRs accumulated there (including the pending PR #207 ), so might be a good moment to port it to the
mainbranch, hence this PR.