Fix git dependencies #208
Merged
Fix git dependencies #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winderica
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Agreed! Thank you for your comment in #146 (comment) as well as this PR that addresses it!
In fact, we didn't switch to fixed revs because we hope to replace all forks with crates.io dependencies very soon (the acvm PR has already been merged and I believe a release is coming, and ark-circom also has supported arkworks 0.5.0). However, it is still very nice to have fixed revs now, so we no longer need to worry about upstream changes that accidentally break sonobe!
Merged
via the queue into
privacy-scaling-explorations:main
with commit Feb 18, 2025
d53ac2e
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should rely on fixed revs, instead of branches to avoid silent breakage / uncontrolled changes.