Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deployer): add service in maci repo #2138

Merged
merged 1 commit into from
Feb 28, 2025
Merged

feat(deployer): add service in maci repo #2138

merged 1 commit into from
Feb 28, 2025

Conversation

NicoSerranoP
Copy link
Member

@NicoSerranoP NicoSerranoP commented Feb 13, 2025

Description

We are moving the coordinator service (built in NestJS) to the MACI protocol repository. This service allows users to deploy MACI and polls using a easy-to-use REST API service.

Completed

  • Deploy and poll services with latest maci-contracts version (v3)
  • Use poseidon contracts already deployed (to save gas and avoid deployment issues)
  • Use of maci-sdk instead of maci-cli and maci-contracts
  • e2e tests to explain how the AA feature works (smart accounts, session keys, etc)
  • e2e tests to deploy a subgraph
  • Finish e2e tests to deploy MACI
  • /coordinator/scripts/getAuthHeader.ts to get a signed header for test requests
  • Added README.md files to each module to explain what they do / how they work

Pending

  • Finish e2e test to vote (3 test users)
  • Finish e2e test to generate proofs
  • Finish e2e test to merge
  • Finish e2e test to submit

Related issue(s)

  1. This was a task in the maci-platform repo
  2. A related issue is: fix consolidate maci deployment steps #1516

Confirmation

Important

We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical error feel free to message the team.

Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Feb 28, 2025 7:15pm

Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I left some comments to address

Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NicoSerranoP thanks, left some comments

feat(deployer): testing e2e

feat(coordinator): comment out send gas func in tests

feat(coordinator): deploy maci and deploy poll works

feat(coordinator): re-organize tests

feat(coordinator): send json in endpoints

feat(coordinator): recharge gas + subgraph deploy + prove tests

feat(coordinator): deploy subgraph correctly + vote in poll

feat(coordinator): rebase with sdk

feat(coordinator): add service in maci repo
@0xmad 0xmad force-pushed the feat/deployer-service branch from 1db51b5 to 3cbf167 Compare February 28, 2025 19:10
@0xmad 0xmad enabled auto-merge February 28, 2025 19:13
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NicoSerranoP thanks!

@0xmad 0xmad merged commit d88b4c5 into dev Feb 28, 2025
23 checks passed
@0xmad 0xmad deleted the feat/deployer-service branch February 28, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

consolidate maci deployment steps
3 participants