-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deployer): add service in maci repo #2138
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I left some comments to address
6c72fa9
to
b4358b4
Compare
b4358b4
to
9b4fef8
Compare
9b4fef8
to
75d3289
Compare
apps/coordinator/ts/auth/__tests__/AccountSignatureGuard.test.ts
Dismissed
Show dismissed
Hide dismissed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NicoSerranoP thanks, left some comments
75d3289
to
a5c02a5
Compare
a5c02a5
to
1db51b5
Compare
feat(deployer): testing e2e feat(coordinator): comment out send gas func in tests feat(coordinator): deploy maci and deploy poll works feat(coordinator): re-organize tests feat(coordinator): send json in endpoints feat(coordinator): recharge gas + subgraph deploy + prove tests feat(coordinator): deploy subgraph correctly + vote in poll feat(coordinator): rebase with sdk feat(coordinator): add service in maci repo
1db51b5
to
3cbf167
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NicoSerranoP thanks!
Description
We are moving the coordinator service (built in NestJS) to the MACI protocol repository. This service allows users to deploy MACI and polls using a easy-to-use REST API service.
Completed
maci-contracts
version (v3)maci-sdk
instead ofmaci-cli
andmaci-contracts
/coordinator/scripts/getAuthHeader.ts
to get a signed header for test requestsPending
Related issue(s)
maci-platform
repoConfirmation
Important
We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical error feel free to message the team.