Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contracts): target field conflict with ethers #33

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Mar 6, 2025

Rename target to recipient

Related to privacy-scaling-explorations/maci#1926

@0xmad 0xmad added the bug Something isn't working label Mar 6, 2025
@0xmad 0xmad requested review from 0xjei and ctrlc03 March 6, 2025 00:41
@0xmad 0xmad self-assigned this Mar 6, 2025
@0xmad 0xmad marked this pull request as ready for review March 6, 2025 00:43
@0xmad 0xmad force-pushed the fix/target-conflict branch from 8226e61 to f02698b Compare March 6, 2025 19:30
@0xmad 0xmad requested a review from ctrlc03 March 6, 2025 19:32
Copy link
Member

@0xjei 0xjei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still some recipients to change!

@0xmad 0xmad force-pushed the fix/target-conflict branch from f02698b to cfb8475 Compare March 6, 2025 20:47
@0xmad 0xmad requested a review from 0xjei March 6, 2025 20:47
@0xmad 0xmad merged commit c3ea3e5 into main Mar 6, 2025
2 checks passed
@0xmad 0xmad deleted the fix/target-conflict branch March 6, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants