Skip to content

Commit 36bf13a

Browse files
authored
Merge pull request #23 from privacy-scaling-explorations/chore/cleanup
Minor issues & cleanup
2 parents 07bf4d6 + 60b5edd commit 36bf13a

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

73 files changed

+6688
-18352
lines changed

.commitlintrc.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,11 @@ const fs = require("node:fs")
22
const path = require("node:path")
33

44
const packages = fs.readdirSync(path.resolve(__dirname, "packages"))
5-
const apps = fs.readdirSync(path.resolve(__dirname, "apps"))
65

76
module.exports = {
87
extends: ["@commitlint/config-conventional"],
98
prompt: {
10-
scopes: [...packages, ...apps],
9+
scopes: [...packages],
1110
markBreakingChangeMode: true,
1211
allowCustomIssuePrefix: false,
1312
allowEmptyIssuePrefix: false,

.eslintignore

-4
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,6 @@ dist
2323
build
2424
/docs
2525

26-
# Docusaurus cache and generated files
27-
.docusaurus
28-
.cache-loader
29-
3026
# misc
3127
.DS_Store
3228
*.pem

.github/workflows/main.yml

-8
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,6 @@ jobs:
3737
files_yaml: |
3838
contracts:
3939
- packages/contracts/**/*.{js,json,ts,sol}
40-
docs:
41-
- apps/docs/**/*
4240
packages:
4341
- packages/**/*.{js,json,ts}
4442
- '!packages/{contracts}/**/*'
@@ -53,12 +51,6 @@ jobs:
5351
yarn compile:contracts
5452
yarn workspace excubiae-contracts lint
5553
56-
- if: steps.changed-files.outputs.docs_any_changed == 'true'
57-
name: Build and format docs
58-
run: |
59-
yarn workspace excubiae-docs build
60-
yarn workspace excubiae-docs format
61-
6254
- if: steps.changed-files.outputs.packages_any_changed == 'true'
6355
name: Build packages
6456
run: yarn build:packages

.gitignore

-4
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,6 @@ build
6565
dist
6666
/docs
6767

68-
# Docusaurus cache and generated files
69-
.docusaurus
70-
.cache-loader
71-
7268
# Hardhat
7369
artifacts
7470
cache

.prettierignore

-4
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,6 @@ build
2626
# github
2727
.github/ISSUE_TEMPLATE
2828

29-
# Docusaurus cache and generated files
30-
.docusaurus
31-
.cache-loader
32-
3329
# mdx file
3430
*.mdx
3531

.yarn/releases/yarn-4.5.0.cjs

-925
This file was deleted.

.yarn/releases/yarn-4.6.0.cjs

+934
Large diffs are not rendered by default.

.yarnrc.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
yarnPath: .yarn/releases/yarn-4.5.0.cjs
2-
31
checksumBehavior: update
42

53
compressionLevel: mixed
64

75
enableGlobalCache: false
86

97
nodeLinker: node-modules
8+
9+
yarnPath: .yarn/releases/yarn-4.6.0.cjs

CODE_OF_CONDUCT.md

+127
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,127 @@
1+
# Contributor Covenant Code of Conduct
2+
3+
## Our Pledge
4+
5+
We as members, contributors, and leaders pledge to make participation in our
6+
community a harassment-free experience for everyone, regardless of age, body
7+
size, visible or invisible disability, ethnicity, sex characteristics, gender
8+
identity and expression, level of experience, education, socio-economic status,
9+
nationality, personal appearance, race, religion, or sexual identity
10+
and orientation.
11+
12+
We pledge to act and interact in ways that contribute to an open, welcoming,
13+
diverse, inclusive, and healthy community.
14+
15+
## Our Standards
16+
17+
Examples of behavior that contributes to a positive environment for our
18+
community include:
19+
20+
- Demonstrating empathy and kindness toward other people
21+
- Being respectful of differing opinions, viewpoints, and experiences
22+
- Giving and gracefully accepting constructive feedback
23+
- Accepting responsibility and apologizing to those affected by our mistakes,
24+
and learning from the experience
25+
- Focusing on what is best not just for us as individuals, but for the
26+
overall community
27+
28+
Examples of unacceptable behavior include:
29+
30+
- The use of sexualized language or imagery, and sexual attention or
31+
advances of any kind
32+
- Trolling, insulting or derogatory comments, and personal or political attacks
33+
- Public or private harassment
34+
- Publishing others' private information, such as a physical or email
35+
address, without their explicit permission
36+
- Other conduct which could reasonably be considered inappropriate in a
37+
professional setting
38+
39+
## Enforcement Responsibilities
40+
41+
Community leaders are responsible for clarifying and enforcing our standards of
42+
acceptable behavior and will take appropriate and fair corrective action in
43+
response to any behavior that they deem inappropriate, threatening, offensive,
44+
or harmful.
45+
46+
Community leaders have the right and responsibility to remove, edit, or reject
47+
comments, commits, code, wiki edits, issues, and other contributions that are
48+
not aligned to this Code of Conduct, and will communicate reasons for moderation
49+
decisions when appropriate.
50+
51+
## Scope
52+
53+
This Code of Conduct applies within all community spaces, and also applies when
54+
an individual is officially representing the community in public spaces.
55+
Examples of representing our community include using an official e-mail address,
56+
posting via an official social media account, or acting as an appointed
57+
representative at an online or offline event.
58+
59+
## Enforcement
60+
61+
Instances of abusive, harassing, or otherwise unacceptable behavior may be
62+
reported to the community leaders responsible for enforcement.
63+
All complaints will be reviewed and investigated promptly and fairly.
64+
65+
All community leaders are obligated to respect the privacy and security of the
66+
reporter of any incident.
67+
68+
## Enforcement Guidelines
69+
70+
Community leaders will follow these Community Impact Guidelines in determining
71+
the consequences for any action they deem in violation of this Code of Conduct:
72+
73+
### 1. Correction
74+
75+
**Community Impact**: Use of inappropriate language or other behavior deemed
76+
unprofessional or unwelcome in the community.
77+
78+
**Consequence**: A private, written warning from community leaders, providing
79+
clarity around the nature of the violation and an explanation of why the
80+
behavior was inappropriate. A public apology may be requested.
81+
82+
### 2. Warning
83+
84+
**Community Impact**: A violation through a single incident or series
85+
of actions.
86+
87+
**Consequence**: A warning with consequences for continued behavior. No
88+
interaction with the people involved, including unsolicited interaction with
89+
those enforcing the Code of Conduct, for a specified period of time. This
90+
includes avoiding interactions in community spaces as well as external channels
91+
like social media. Violating these terms may lead to a temporary or
92+
permanent ban.
93+
94+
### 3. Temporary Ban
95+
96+
**Community Impact**: A serious violation of community standards, including
97+
sustained inappropriate behavior.
98+
99+
**Consequence**: A temporary ban from any sort of interaction or public
100+
communication with the community for a specified period of time. No public or
101+
private interaction with the people involved, including unsolicited interaction
102+
with those enforcing the Code of Conduct, is allowed during this period.
103+
Violating these terms may lead to a permanent ban.
104+
105+
### 4. Permanent Ban
106+
107+
**Community Impact**: Demonstrating a pattern of violation of community
108+
standards, including sustained inappropriate behavior, harassment of an
109+
individual, or aggression toward or disparagement of classes of individuals.
110+
111+
**Consequence**: A permanent ban from any sort of public interaction within
112+
the community.
113+
114+
## Attribution
115+
116+
This Code of Conduct is adapted from the [Contributor Covenant][homepage],
117+
version 2.0, available at
118+
https://www.contributor-covenant.org/version/2/0/code_of_conduct.html.
119+
120+
Community Impact Guidelines were inspired by [Mozilla's code of conduct
121+
enforcement ladder](https://github.com/mozilla/diversity).
122+
123+
[homepage]: https://www.contributor-covenant.org
124+
125+
For answers to common questions about this code of conduct, see the FAQ at
126+
https://www.contributor-covenant.org/faq. Translations are available at
127+
https://www.contributor-covenant.org/translations.

CONTRIBUTING.md

+113
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,113 @@
1+
# Contributing
2+
3+
:tada: Thank you for being interested in contributing to the Excubiae project! :tada:
4+
5+
Feel welcome and read the following sections in order to know how to ask questions and how to work on something.
6+
7+
All members of our community are expected to follow our [Code of Conduct](/CODE_OF_CONDUCT.md). Please make sure you are welcoming and friendly in all of our spaces.
8+
9+
We're really glad you're reading this, because we need volunteer developers to help this project come to fruition. 👏
10+
11+
## Issues
12+
13+
The best way to contribute to our projects is by opening a [new issue](https://github.com/semaphore-protocol/semaphore/issues/new/choose) or tackling one of the issues listed [here](https://github.com/semaphore-protocol/semaphore/contribute).
14+
15+
## Pull Requests
16+
17+
Pull requests are great if you want to add a feature or fix a bug. Here's a quick guide:
18+
19+
1. Fork the repo.
20+
21+
2. Run the tests. We only take pull requests with passing tests.
22+
23+
3. Add a test for your change. Only refactoring and documentation changes require no new tests.
24+
25+
4. Make sure to check out the [Style Guide](/CONTRIBUTING.md#style-guide) and ensure that your code complies with the rules.
26+
27+
5. Make the test pass.
28+
29+
6. Commit your changes.
30+
31+
7. Push to your fork and submit a pull request on our `main` branch. Please provide us with some explanation of why you made the changes you made. For new features make sure to explain a standard use case to us.
32+
33+
> [!IMPORTANT]
34+
> We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical error feel free to message the team.
35+
36+
## CI (Github Actions) Tests
37+
38+
We use GitHub Actions to test each PR before it is merged.
39+
40+
When you submit your PR (or later change that code), a CI build will automatically be kicked off. A note will be added to the PR, and will indicate the current status of the build.
41+
42+
## Style Guide
43+
44+
### Code rules
45+
46+
We always use ESLint and Prettier. To check that your code follows the rules, simply run the npm script `yarn lint`.
47+
48+
### Commit rules
49+
50+
For commits it is recommended to use [Conventional Commits](https://www.conventionalcommits.org).
51+
52+
Don't worry if it looks complicated, in our repositories, `git commit` opens an interactive app to create your conventional commit.
53+
54+
Each commit message consists of a **header**, a **body** and a **footer**. The **header** has a special format that includes a **type**, a **scope** and a **subject**:
55+
56+
<type>(<scope>): <subject>
57+
<BLANK LINE>
58+
<body>
59+
<BLANK LINE>
60+
<footer>
61+
62+
The **header** is mandatory and the **scope** of the header must contain the name of the package you are working on.
63+
64+
#### Type
65+
66+
The type must be one of the following:
67+
68+
- feat: A new feature
69+
- fix: A bug fix
70+
- docs: Documentation only changes
71+
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
72+
- refactor: A code change that neither fixes a bug nor adds a feature (improvements of the code structure)
73+
- perf: A code change that improves the performance
74+
- test: Adding missing or correcting existing tests
75+
- build: Changes that affect the build system or external dependencies (example scopes: gulp, npm)
76+
- ci: Changes to CI configuration files and scripts (example scopes: travis, circle)
77+
- chore: Other changes that don't modify src or test files
78+
- revert: Reverts a previous commit
79+
80+
#### Scope
81+
82+
The scope should be the name of the npm package affected (as perceived by the person reading the changelog generated from commit messages).
83+
84+
#### Subject
85+
86+
The subject contains a succinct description of the change:
87+
88+
- Use the imperative, present tense: "change" not "changed" nor "changes"
89+
- Don't capitalize the first letter
90+
- No dot (.) at the end
91+
92+
#### Body
93+
94+
Just as in the subject, use the imperative, present tense: "change" not "changed" nor "changes". The body should include the motivation for the change and contrast this with previous behavior.
95+
96+
### Branch rules
97+
98+
- There must be a `main` branch, used only for the releases.
99+
- Avoid long descriptive names for long-lived branches.
100+
- Use kebab-case (no CamelCase).
101+
- Use grouping tokens (words) at the beginning of your branch names (in a similar way to the `type` of commit).
102+
- Define and use short lead tokens to differentiate branches in a way that is meaningful to your workflow.
103+
- Use slashes to separate parts of your branch names.
104+
- Remove branch after merge if it is not important.
105+
106+
Examples:
107+
108+
```bash
109+
git branch -b docs/readme
110+
git branch -b test/a-feature
111+
git branch -b feat/sidebar
112+
git branch -b fix/b-feature
113+
```

LICENSE

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
MIT License
22

3-
Copyright (c) 2024 Privacy & Scaling Explorations
3+
Copyright (c) 2025 Privacy & Scaling Explorations
44

55
Permission is hereby granted, free of charge, to any person obtaining a copy
66
of this software and associated documentation files (the "Software"), to deal

README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ It provides a set of abstract and flexible smart contracts, known as "gatekeeper
66

77
This approach enables seamless interoperability across different protocols. For instance, a single check could combine verifiable attributes from Semaphore and MACI, ensuring flexible and composable access control. Indeed, for example, you can define criteria to verify token ownership and/or validate a zero-knowledge proof (ZKP). Using these criteria, you can create a policy to enforce the checks and integrate it seamlessly into your smart contract logic. A practical use case might involve requiring verification before registering a new voter for a poll (e.g., in a MACI-based voting system).
88

9-
You can learn more in this [design document](https://hackmd.io/@0xjei/B1RXoTh71e).
9+
You can learn more in this [technical reference document](https://hackmd.io/@0xjei/B1RXoTh71e).
1010

1111
> [!IMPORTANT]
12-
> Excubiae is currently in the MVP stage. Official documentation and audits are not yet available. Expect fast development cycles with potential breaking changes — use at your own risk!
12+
> Excubiae is currently in the MVP stage. Official documentation website and audits are not yet available. Expect fast development cycles with potential breaking changes — use at your own risk! Please, refer to [release](https://github.com/privacy-scaling-explorations/excubiae/releases) section for latest changes and updates.
1313
1414
## Installation
1515

@@ -59,7 +59,7 @@ yarn test
5959

6060
### Build
6161

62-
Build all packages & apps:
62+
Build all packages:
6363

6464
```bash
6565
yarn build

apps/docs/.gitignore

-20
This file was deleted.

0 commit comments

Comments
 (0)