Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable: sorting null not properly working #681

Closed
mleonhartsberger opened this issue Jul 29, 2016 · 4 comments
Closed

DataTable: sorting null not properly working #681

mleonhartsberger opened this issue Jul 29, 2016 · 4 comments
Assignees
@cagataycivici
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
1.0.0-RC1

Comments

@mleonhartsberger
Copy link

when sorting a column which contains some rows with "value is null", the sort algorythm just stops.

it could be solved by adding null checks at
https://github.com/primefaces/primeng/blob/master/components/datatable/datatable.ts#L575

image
@edangerfield
Copy link

I experience the same.

@xlyds
Copy link

xlyds commented Sep 23, 2016

+1

@kt215 kt215 mentioned this issue Oct 31, 2016
Merged
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Nov 1, 2016
@cagataycivici cagataycivici added this to the 1.0.0-RC1 milestone Nov 1, 2016
@cagataycivici cagataycivici self-assigned this Nov 1, 2016
antkers added a commit to antkers/primeng that referenced this issue Dec 14, 2017
@antkers
Update datatable.ts
9f07b49 
Fix for multiple fields sort when a field's value is null.
It was already fixed for single field sorting, see issue primefaces#681
antkers added a commit to antkers/primeng that referenced this issue Dec 14, 2017
@antkers
Update datatable.ts
c1a09da 
Fix for multiple fields sort when a field's value is null.
It was already fixed for single field sorting, see issue primefaces#681
@antkers antkers mentioned this issue Dec 14, 2017
Closed
@ctrl-brk
Copy link

ctrl-brk commented Feb 16, 2018 •
edited
Loading

Same issue still exists in multisort mode

@afras21
Copy link

afras21 commented Oct 10, 2018

Yeah the actual problem is null property is string and others are numbers .... change them to string it ll work fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
1.0.0-RC1
Development

No branches or pull requests
6 participants
@cagataycivici @edangerfield @xlyds @ctrl-brk @mleonhartsberger @afras21