Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missed sources for source maps #672

Closed
kkovalevskiy opened this issue Jul 28, 2016 · 0 comments
Closed

Missed sources for source maps #672

kkovalevskiy opened this issue Jul 28, 2016 · 0 comments
Assignees
@cagataycivici
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
1.0.0-RC1

Comments

@kkovalevskiy
Copy link

kkovalevskiy commented Jul 28, 2016 •
edited
Loading

Looks like there is no original sources in *.js.map files. For example primeng.js.map refers on primeng.ts file, but there is no such file in final bundle and also there is no inlined sources in source maps. This makes debugging of primeng a bit harder than it should be. So there could be 2 options:

  1. Add sources to final bundle and make sure that *.js.map files refer them correctly.
  2. Add "inlineSources": true to the tsconfig.json file.

The last option is more preferable than the first one
JFYI: I'm using 1.0.0-beta.11 version
kkovalevskiy pushed a commit to kkovalevskiy/primeng that referenced this issue Aug 3, 2016
Fixed issue primefaces#672
d8c95c5
@kkovalevskiy kkovalevskiy mentioned this issue Aug 3, 2016
Merged
cagataycivici added a commit that referenced this issue Oct 29, 2016
@cagataycivici
Merge pull request #691 from kkovalevskiy/issue-672
e608155 
Fixed issue #672
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Oct 29, 2016
@cagataycivici cagataycivici added this to the 1.0.0-RC1 milestone Oct 29, 2016
@cagataycivici cagataycivici self-assigned this Oct 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
1.0.0-RC1
Development

No branches or pull requests
2 participants
@cagataycivici @kkovalevskiy