[PLATFORM-864]: Add Redactable trait to Veil, for manually redacting structured data #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaeIsBad
reviewed
Dec 19, 2022
WilliamVenner
force-pushed
the
PLATFORM-864/user-story/add-redactable-trait-to-veil-for-manually-redacting-structured-data
branch
from
9389e1e to
7401cb2
Compare
|
Rerequest review so I know when you're done 🙏 |
MaeIsBad
reviewed
Dec 20, 2022
src/util.rs
Outdated
| @@ -1,38 +1,26 @@ | |||
| /// HACK! To reduce code duplication in the generated binary, this macro is used to generate a | |||
| /// HACK! To reduce code duplication in the generated binary, this function is used to generate a | |||
There was a problem hiding this comment.
code duplication in the generated binary
I don't think this reduces code duplication in the binary, right? Since the struct is a generic this does reduce the amount of source code written, but I don't think it has any impact on the generated code
There was a problem hiding this comment.
I clarified the meaning of the comment. If we made the functions in the private module generic, it would lead to code duplication, is what I meant
MaeIsBad
approved these changes
Dec 20, 2022
WilliamVenner
deleted the
PLATFORM-864/user-story/add-redactable-trait-to-veil-for-manually-redacting-structured-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://prima-assicurazioni-spa.myjetbrains.com/youtrack/issue/PLATFORM-864
This PR introduces the
Redactabletrait, one method of manually redacting data.This allows users to explicitly call
.redact()or.redact_into()on a type to get redacted data back from it.The trait can be derived using the newly introduced derive macro, or manually implemented for a type by hand.